Skip to content

Conversation

@MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Dec 22, 2024

Type of change

  • Bug

Proposed commit message

A recent update to Arista NG Firewall changed the Syslog message format slightly. Where there used to be two spaces preceding the message body, the new format only includes a single space. The updated Grok pattern accounts for both the old, double-spaced format and the new single-spaced format.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Tested changes locally

How to test this PR locally

Modified the default ingest pipeline with the proposed Grok pattern change, and the messages are now parsing again properly.

Related issues

@MakoWish MakoWish changed the title Correct Grok pattern due to change in Syslog message format. [Arista NG Firewall] Correct Grok pattern due to change in Syslog message format. Dec 22, 2024
@MakoWish MakoWish marked this pull request as ready for review December 22, 2024 16:43
@MakoWish MakoWish requested a review from a team as a code owner December 22, 2024 16:43
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:arista_ngfw Arista NG Firewall (Community supported) Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Dec 23, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@mjwolf
Copy link
Contributor

mjwolf commented Dec 27, 2024

/test

@elasticmachine
Copy link

💚 Build Succeeded

@mjwolf
Copy link
Contributor

mjwolf commented Dec 27, 2024

Hi @MakoWish, could you edit the proposed commit message to remove the markdown formatting, since git commit messages aren't markdown? Otherwise, this looks good to me.

@MakoWish
Copy link
Contributor Author

Yessir! It has been updated.

@mjwolf mjwolf merged commit f1cf1eb into elastic:main Dec 29, 2024
5 checks passed
@elastic-vault-github-plugin-prod

Package arista_ngfw - 1.2.1 containing this change is available at https://epr.elastic.co/package/arista_ngfw/1.2.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…sage format. (elastic#12176) A recent update to Arista NG Firewall changed the Syslog message format slightly. Where there used to be two spaces preceding the message body, the new format only includes a single space. The updated Grok pattern accounts for both the old, double-spaced format and the new single-spaced format.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…sage format. (elastic#12176) A recent update to Arista NG Firewall changed the Syslog message format slightly. Where there used to be two spaces preceding the message body, the new format only includes a single space. The updated Grok pattern accounts for both the old, double-spaced format and the new single-spaced format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:arista_ngfw Arista NG Firewall (Community supported) Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

4 participants