Skip to content

Conversation

@GShepherdTC
Copy link
Contributor

Proposed commit message

Updated the base query to include the latest index so indicators are not counted twice for all the
panels in the dashboard. Updated 1 label to show its unique indicators being counted.

Checklist

  • [X ] I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • existing dashboard updates

How to test this PR locally

Run the integration and view the dashboard is reflecting correct counts now.

Related issues

Screenshots

@GShepherdTC GShepherdTC marked this pull request as ready for review December 13, 2024 20:51
@GShepherdTC GShepherdTC requested a review from a team as a code owner December 13, 2024 20:51
Copy link
Contributor Author

@GShepherdTC GShepherdTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always for the review.

Copy link
Contributor Author

@GShepherdTC GShepherdTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.

@efd6 efd6 changed the title Bug: New query to base dashboard to avoid duplicates. Update label. ti_threatconnect: add query to base dashboard to avoid duplicates and update label Dec 16, 2024
@andrewkroh andrewkroh added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:ti_threatconnect ThreatConnect (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Dec 16, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6
Copy link
Contributor

efd6 commented Dec 16, 2024

/test

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh
Copy link
Member

/test

@andrewkroh andrewkroh enabled auto-merge (squash) January 3, 2025 23:35
@andrewkroh andrewkroh merged commit 9725499 into elastic:main Jan 3, 2025
3 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #19576 succeeded 79c32fb3558ff9396eaa5fdc433b9e44d5e7404b
@elastic-vault-github-plugin-prod

Package ti_threatconnect - 1.7.0 containing this change is available at https://epr.elastic.co/package/ti_threatconnect/1.7.0/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…#12106) Updated the base query to only use the latest index so indicators are not counted twice for all the panels in the dashboard. Updated one visualization label to show its unique indicators being counted.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…#12106) Updated the base query to only use the latest index so indicators are not counted twice for all the panels in the dashboard. Updated one visualization label to show its unique indicators being counted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:ti_threatconnect ThreatConnect (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants