Skip to content

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Dec 12, 2024

Proposed commit message

The source.ip field is never set, so this is redundant.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added Integration:mimecast Mimecast (Partner supported) bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Dec 12, 2024
@efd6 efd6 self-assigned this Dec 12, 2024
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Dec 12, 2024

🚀 Benchmarks report

Package mimecast 👍(4) 💚(5) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
ttp_ip_logs 20408.16 16129.03 -4279.13 (-20.97%) 💔
ttp_ap_logs 10752.69 8695.65 -2057.04 (-19.13%) 💔

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review December 12, 2024 22:00
@efd6 efd6 requested a review from a team as a code owner December 12, 2024 22:00
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #19427 succeeded 0d6c01e54cc515e6ea476593a131942bbd3a82de

cc @efd6

@efd6 efd6 merged commit 799df4f into elastic:main Dec 13, 2024
5 checks passed
@elastic-vault-github-plugin-prod

Package mimecast - 2.4.1 containing this change is available at https://epr.elastic.co/package/mimecast/2.4.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
The source.ip field is never set, so this is redundant.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
The source.ip field is never set, so this is redundant.
@efd6 efd6 deleted the 12076-mimecast branch February 5, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:mimecast Mimecast (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants