Skip to content

packages/prometheus: Upgrade to package format_version v3 #11988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Dec 5, 2024
Merged

packages/prometheus: Upgrade to package format_version v3 #11988

merged 0 commits into from
Dec 5, 2024

Conversation

@shmsr
Copy link
Member

@shmsr shmsr commented Dec 3, 2024 •
edited
Loading

Proposed commit message

Upgrade to package format_version v3. Tested using elastic-package (pipeline, static, etc.) and also linting and building. Also did basic testing by scraping data from Prometheus Server itself and populating the dashboard. Works as expected. For testing, I used 8.16.1 cluster.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

#8028

Screenshots

Dashboards screenshots after using collector to scrape metrics from Prometheus Server itself.

Screenshot 2024-12-04 at 11 21 22 PM Screenshot 2024-12-04 at 11 21 51 PM
@shmsr shmsr self-assigned this Dec 3, 2024
@shmsr shmsr added the enhancement New feature or request label Dec 3, 2024
@shmsr shmsr requested review from ishleenk17 and muthu-mps December 3, 2024 17:54
@shmsr shmsr marked this pull request as ready for review December 4, 2024 05:11
@shmsr shmsr requested review from a team as code owners December 4, 2024 05:11
@ishleenk17
Copy link
Member

ishleenk17 commented Dec 4, 2024

Nice to see that we did not have to exclude any checks in validaton.yml
@shmsr
Copy link
Member Author

shmsr commented Dec 4, 2024

@elastic/obs-cloudnative-monitoring Could someone PTAL? Thank you!
muthu-mps
muthu-mps reviewed Dec 4, 2024
View reviewed changes
@shmsr
Copy link
Member Author

shmsr commented Dec 4, 2024

Also upgraded to latest package-spec: https://github.com/elastic/package-spec/blob/9ad6feb0a29d607f3a1186a41a8d28b82be4dd4b/spec/changelog.yml#L21 i.e., 3.3.0
@elasticmachine
Copy link

elasticmachine commented Dec 4, 2024

💚 Build Succeeded

History

  • 💚 Build #19038 succeeded bdfea52ff159f02e2c72bac61288ab34d8ce348e
  • 💔 Build #19035 failed 104e3d234393f3d2ee135bd89a4640d9541a6e64

cc @shmsr
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Dec 4, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@andrewkroh andrewkroh added Team:Cloudnative-Monitoring Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Dec 4, 2024
@gizas
Copy link
Contributor

gizas commented Dec 4, 2024

LGTM!
I only did a package build! Apart from that it would be useful to such stories to add the screenshots section or some verification logs that some basic tests had run and nothing broke
@shmsr
Copy link
Member Author

shmsr commented Dec 4, 2024 •
edited
Loading

@gizas Makes sense. I should've put it. So for testing I have all the elastic-package tests (e.g., pipeline, static, etc.), and also linting to check for validations (SRV...). Everything looks good. I did basic testing by scraping data from Prometheus Server itself and populated the dashboard. I'll put the pics here:

Screenshot 2024-12-04 at 11 21 22 PM Screenshot 2024-12-04 at 11 21 51 PM

I have also updated the PR description.
@shmsr shmsr merged commit e0f1121 into elastic:main Dec 5, 2024
5 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Dec 5, 2024

Package prometheus - 1.21.0 containing this change is available at https://epr.elastic.co/package/prometheus/1.21.0/
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@shmsr
packages/prometheus: Upgrade to package format_version v3 (elastic#11988
93236ba 
)
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@shmsr
packages/prometheus: Upgrade to package format_version v3 (elastic#11988
6b847bd 
)
@shmsr shmsr deleted the prometheus_pkg_format_upgrade branch February 6, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:prometheus Prometheus Team:Cloudnative-Monitoring Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

7 participants

@shmsr @ishleenk17 @elasticmachine @gizas @tetianakravchenko @muthu-mps @andrewkroh