Skip to content

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Nov 28, 2024

Proposed commit message

mimecast: add cloud integrated logs data stream Tested against a real endpoint. Pipeline test cases obtained from a test instance. Up to 10 examples of each available type are included. Not all types are represented. 

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:mimecast Mimecast (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Nov 28, 2024
@efd6 efd6 self-assigned this Nov 28, 2024
@efd6 efd6 force-pushed the 11160-mimecast branch 3 times, most recently from 9a8e16f to 59d91bf Compare November 28, 2024 02:07
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 28, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review November 28, 2024 02:45
@efd6 efd6 requested a review from a team as a code owner November 28, 2024 02:45
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentionally not logged.

@efd6 efd6 force-pushed the 11160-mimecast branch 3 times, most recently from b642d1f to 259fc85 Compare December 9, 2024 23:18
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit.
LGTM Otherwise 👍🏼

Comment on lines 55 to 56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
threats and security events with the following details: entities, mail flows and URL
protected event. More information about [these logs](
threats and security events with the following details: entities, mail flows, and URL
protected events. More information about [these logs](
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a field named recipients. Can it be used for email.to and also into related.user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That processor exists, but it was wrong.

@efd6 efd6 enabled auto-merge (squash) December 12, 2024 08:54
@efd6 efd6 disabled auto-merge December 12, 2024 09:10
@efd6 efd6 enabled auto-merge (squash) December 12, 2024 09:11
@efd6 efd6 merged commit 092dc86 into elastic:main Dec 12, 2024
3 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #19250 succeeded 259fc8569c571d2c2e5298e0fccf35a9909df02a
  • 💚 Build #19211 succeeded b642d1f76df0f9d597d0c7ef03510e6f92ba3d5a
  • 💚 Build #19100 succeeded 03d8d555f0c293eb377eb26477df9b80b5b51a0f
  • 💚 Build #18821 succeeded 59d91bf36b42387cd59b44fca9cdc2cb0cbce4f5

cc @efd6

@elastic-vault-github-plugin-prod

Package mimecast - 2.3.0 containing this change is available at https://epr.elastic.co/package/mimecast/2.3.0/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
Tested against a real endpoint. Pipeline test cases obtained from a test instance. Up to 10 examples of each available type are included. Not all types are represented.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
Tested against a real endpoint. Pipeline test cases obtained from a test instance. Up to 10 examples of each available type are included. Not all types are represented.
@efd6 efd6 deleted the 11160-mimecast branch February 5, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:mimecast Mimecast (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants