cisco_duo: Make retry options configurable in CEL-based datastreams #11822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kcreddy added Integration:cisco_duo 
🚀 Benchmarks reportPackage |
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
activity | 3649.64 | 2857.14 | -792.5 (-21.71%) | 💔 |
telephony_v2 | 22222.22 | 14925.37 | -7296.85 (-32.84%) | 💔 |
trust_monitor | 16393.44 | 9345.79 | -7047.65 (-42.99%) | 💔 |
To see the full report comment with /test benchmark fullreport
kcreddy added the Team:Security-Service Integrations 
| Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
chemamartinez left a comment
chemamartinez left a comment There was a problem hiding this comment.
It may be worthy to include the same options for the rest of the data streams using CEL
Contributor Author
Agreed. Will do |
kcreddy changed the title 
|
💚 Build Succeeded
History
cc @kcreddy |
| Package cisco_duo - 2.2.6 containing this change is available at https://epr.elastic.co/package/cisco_duo/2.2.6/ |
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
…11822) Cisco Duo Admin API has very low API request limit (Ex: `not more than 1 request per minute` for Authentication logs). Reaching this limit would lead to `42901` from the API. The response also doesn't include a `Retry-After` header, which leads to a default back-off retry attempts. This subsequently leads to further `42901` as the limit is already reached. This PR allows users to set optional retry configuration allowed by CEL input for CEL-based data-streams. When number of retries are reduces, this helps in reducing the number retry requests being made when already reached `429`.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…lastic#11822) Cisco Duo Admin API has very low API request limit (Ex: `not more than 1 request per minute` for Authentication logs). Reaching this limit would lead to `42901` from the API. The response also doesn't include a `Retry-After` header, which leads to a default back-off retry attempts. This subsequently leads to further `42901` as the limit is already reached. This PR allows users to set optional retry configuration allowed by CEL input for CEL-based data-streams. When number of retries are reduces, this helps in reducing the number retry requests being made when already reached `429`.
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
…11822) Cisco Duo Admin API has very low API request limit (Ex: `not more than 1 request per minute` for Authentication logs). Reaching this limit would lead to `42901` from the API. The response also doesn't include a `Retry-After` header, which leads to a default back-off retry attempts. This subsequently leads to further `42901` as the limit is already reached. This PR allows users to set optional retry configuration allowed by CEL input for CEL-based data-streams. When number of retries are reduces, this helps in reducing the number retry requests being made when already reached `429`.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…lastic#11822) Cisco Duo Admin API has very low API request limit (Ex: `not more than 1 request per minute` for Authentication logs). Reaching this limit would lead to `42901` from the API. The response also doesn't include a `Retry-After` header, which leads to a default back-off retry attempts. This subsequently leads to further `42901` as the limit is already reached. This PR allows users to set optional retry configuration allowed by CEL input for CEL-based data-streams. When number of retries are reduces, this helps in reducing the number retry requests being made when already reached `429`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Cisco Duo Admin API has very low API request limit (Ex:
not more than 1 request per minutefor Authentication logs). Reaching this limit would lead to42901from the API. The response also doesn't include aRetry-Afterheader, which leads to a default back-off retry attempts. This subsequently leads to further42901as the limit is already reached.This PR allows users to set optional retry configuration allowed by CEL input for CEL-based data-streams. When number of retries are reduces, this helps in reducing the number retry requests being made when already reached
429.Reference:
https://help.duo.com/s/article/1338?language=en_US
https://duo.com/docs/adminapi#authentication-logs
https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-cel.html#_resource_retry_max_attempts
Note
This only reduces
42901Too Many Requests from the retry attempts. The users have to tuneIntervalandRate limitto avoid the42901from the initial request (non-retry).Checklist
changelog.ymlfile.Screenshots