Skip to content

Conversation

@lucian-ioan
Copy link
Contributor

Proposed commit message

Removes metrics reference from the manifest.yml file as the integration currently only supports logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@lucian-ioan lucian-ioan added Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] bugfix Pull request that fixes a bug issue Integration:azure_app_service Azure App Service labels Nov 21, 2024
@lucian-ioan lucian-ioan self-assigned this Nov 21, 2024
@lucian-ioan lucian-ioan requested a review from a team as a code owner November 21, 2024 06:15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/12345
link: https://github.com/elastic/integrations/pull/11802
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucian-ioan lucian-ioan enabled auto-merge (squash) November 21, 2024 06:20
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@lucian-ioan lucian-ioan merged commit 7a76a86 into elastic:main Nov 21, 2024
5 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

cc @lucian-ioan

@elastic-vault-github-plugin-prod

Package azure_app_service - 0.4.1 containing this change is available at https://epr.elastic.co/package/azure_app_service/0.4.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@lucian-ioan lucian-ioan deleted the azure_appservice_fix_readme branch February 6, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:azure_app_service Azure App Service Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

3 participants