Skip to content

eset_protect: add HTTP header identifying the integration #11726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Nov 14, 2024
Merged

eset_protect: add HTTP header identifying the integration #11726

merged 0 commits into from
Nov 14, 2024

Conversation

@eset-enterprise-integration
Copy link
Contributor

@eset-enterprise-integration eset-enterprise-integration commented Nov 13, 2024 •
edited by efd6
Loading

Proposed commit message

eset_protect: add HTTP header identifying the integration The ESET Protect API will be requiring an HTTP header, "3rd-integration", to identify integrations. Documentation for the header is not currently available, but will be at the ESET Elastic integration documentation page[1] in the future. [1]https://help.eset.com/eset_connect/en-US/elastic.html

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

We will see changes in our monitoring after release

Related issues

No issue
@eset-enterprise-integration eset-enterprise-integration requested a review from a team as a code owner November 13, 2024 13:57
@cla-checker-service
Copy link

cla-checker-service bot commented Nov 13, 2024 •
edited
Loading

💚 CLA has been signed
@andrewkroh andrewkroh added Integration:eset_protect ESET PROTECT needs CLA User must sign the Elastic Contributor License before review. Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Nov 13, 2024
@elasticmachine
Copy link

elasticmachine commented Nov 13, 2024

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@eset-enterprise-integration
Copy link
Contributor Author

eset-enterprise-integration commented Nov 13, 2024

I have signed CLA
@andrewkroh andrewkroh added enhancement New feature or request and removed needs CLA User must sign the Elastic Contributor License before review. labels Nov 13, 2024
efd6
efd6 reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue that explains why this is happening?

Please add a proposed commit message to the PR description explaining what is being done and why.

The manifest.yml will need a change in the version field to match the entry in the changelog.
@eset-enterprise-integration eset-enterprise-integration changed the title Eset integratin: add header Eset integration: add header Nov 14, 2024
@eset-enterprise-integration
Copy link
Contributor Author

eset-enterprise-integration commented Nov 14, 2024

Is there an issue that explains why this is happening?

Please add a proposed commit message to the PR description explaining what is being done and why.

The manifest.yml will need a change in the version field to match the entry in the changelog.
@efd6
Copy link
Contributor

efd6 commented Nov 14, 2024

/test
@efd6
Copy link
Contributor

efd6 commented Nov 14, 2024

Is there documentation for this in the API docs?
@eset-enterprise-integration
Copy link
Contributor Author

eset-enterprise-integration commented Nov 14, 2024

Is there documentation for this in the API docs?

not yet, we will add it after release
@efd6
Copy link
Contributor

efd6 commented Nov 14, 2024

Ideally, this should go in the commit message.
@eset-enterprise-integration
Copy link
Contributor Author

eset-enterprise-integration commented Nov 14, 2024

/test
we will see changes in our monitoring after release
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 14, 2024

🚀 Benchmarks report

Package eset_protect 👍(1) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
detection 1919.39 1501.5 -417.89 (-21.77%) 💔
event 1996.01 1675.04 -320.97 (-16.08%) 💔

To see the full report comment with /test benchmark fullreport
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Nov 14, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@elasticmachine
Copy link

elasticmachine commented Nov 14, 2024

💚 Build Succeeded
@efd6
Copy link
Contributor

efd6 commented Nov 14, 2024

Sorry, let me clarify: the link to documentation should go in the commit message. If it cannot, I will rewrite the commit message to explain that. This is less than ideal though.
@eset-enterprise-integration
Copy link
Contributor Author

eset-enterprise-integration commented Nov 14, 2024

I add link to commit message. But information about header will be there later. Thanks
@efd6
Copy link
Contributor

efd6 commented Nov 14, 2024 •
edited
Loading

Thanks. Out of curiosity, is there a reason for not using RFC 7231 5.5.3 for this? This is well within what that was designed for.
@efd6 efd6 changed the title Eset integration: add header eset_protect: add HTTP header identifying the integration Nov 14, 2024
@efd6 efd6 merged commit dc620d9 into elastic:main Nov 14, 2024
5 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 14, 2024

Package eset_protect - 1.2.0 containing this change is available at https://epr.elastic.co/package/eset_protect/1.2.0/
@eset-enterprise-integration
Copy link
Contributor Author

eset-enterprise-integration commented Nov 14, 2024

Thanks. Out of curiosity, is there a reason for not using RFC 7231 5.5.3 for this? This is well within what that was designed for.

We didn't know this
@eset-enterprise-integration eset-enterprise-integration deleted the eset/integration branch November 14, 2024 08:01
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@eset-enterprise-integration
eset_protect: add HTTP header identifying the integration (elastic#11726
1f67103 
) The ESET Protect API will be requiring an HTTP header, "3rd-integration", to identify integrations. Documentation for the header is not currently available, but will be at the ESET Elastic integration documentation page[1] in the future. [1]https://help.eset.com/eset_connect/en-US/elastic.html
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@eset-enterprise-integration
eset_protect: add HTTP header identifying the integration (elastic#11726
cd73af7 
) The ESET Protect API will be requiring an HTTP header, "3rd-integration", to identify integrations. Documentation for the header is not currently available, but will be at the ESET Elastic integration documentation page[1] in the future. [1]https://help.eset.com/eset_connect/en-US/elastic.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:eset_protect ESET PROTECT Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants

@eset-enterprise-integration @elasticmachine @efd6 @andrewkroh