Skip to content

Conversation

@maxcold
Copy link
Contributor

@maxcold maxcold commented Oct 28, 2024

Proposed commit message

Update readme to mention the fourth support data stream, Cloud Configuration Finding

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@maxcold maxcold added enhancement New feature or request Team:Service-Integrations Label for the Observability Service Integrations team Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] Integration:wiz Wiz labels Oct 28, 2024
@maxcold maxcold requested a review from a team as a code owner October 28, 2024 11:04
@andrewkroh andrewkroh added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Oct 28, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

## Data streams

The Wiz integration collects three types of data: Audit, Issue and Vulnerability.
The Wiz integration collects four types of data: Audit, Cloud Configuration Finding, Issue and Vulnerability.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be made in _dev/build/docs/README.md and propagated here by elastic-package build.

- version: "1.8.3"
changes:
- description: Add Cloud Configuration Finding to the list of data streams in README
type: enhancement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that this is a bugfix as it's correcting incorrect information. Classing it as a bugfix also has the happy effect that we are not breaking semver semantics.

@maxcold maxcold requested a review from efd6 October 29, 2024 08:55
@elasticmachine
Copy link

🚀 Benchmarks report

Package wiz 👍(0) 💚(0) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 2444.99 1661.13 -783.86 (-32.06%) 💔
cloud_configuration_finding 3861 2320.19 -1540.81 (-39.91%) 💔
issue 2538.07 2061.86 -476.21 (-18.76%) 💔
vulnerability 3215.43 2439.02 -776.41 (-24.15%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue and removed enhancement New feature or request labels Oct 29, 2024
@efd6 efd6 merged commit 0e0b04e into elastic:backport-wiz-1.8 Oct 29, 2024
5 checks passed
@elastic-vault-github-plugin-prod

Package wiz - 1.8.3 containing this change is available at https://epr.elastic.co/search?package=wiz

qcorporation pushed a commit that referenced this pull request Feb 4, 2025
…#11535) Update README to mention the fourth support data stream, "Cloud Configuration Finding".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:wiz Wiz Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Service-Integrations Label for the Observability Service Integrations team

4 participants