Skip to content

[Fortinet Fortigate] swap source and destination for fortigate VPN event #11523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gogochan merged 4 commits into from
Oct 28, 2024
Merged

[Fortinet Fortigate] swap source and destination for fortigate VPN event #11523

gogochan merged 4 commits into from
Oct 28, 2024

Conversation

@gogochan
Copy link
Contributor

@gogochan gogochan commented Oct 25, 2024

Proposed commit message

#9394

This PR fixes VPN events Fortinet Fortigate.

For VPN events, source is the client and the destination is the firewall, therefore the field must be swapped to represent the traffic flow.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@gogochan gogochan added the bug Something isn't working, use only for issues label Oct 25, 2024
@gogochan gogochan requested a review from a team as a code owner October 25, 2024 16:44
@gogochan gogochan added Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Oct 25, 2024
@elasticmachine
Copy link

elasticmachine commented Oct 25, 2024

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 25, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
taylor-swanson
taylor-swanson reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine to me, but perhaps this should be a "minor" version change, since it changes what values we're storing where.

1.25.9 -> 1.26.0
@gogochan
Copy link
Contributor Author

gogochan commented Oct 25, 2024

Change looks fine to me, but perhaps this should be a "minor" version change, since it changes what values we're storing where.

1.25.9 -> 1.26.0

Done ecfb39b
@elasticmachine
Copy link

elasticmachine commented Oct 25, 2024

💚 Build Succeeded

History
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Oct 25, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@gogochan gogochan merged commit 120d3c8 into main Oct 28, 2024
3 checks passed
@gogochan gogochan deleted the fortiGateVPN branch October 28, 2024 13:47
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 28, 2024

Package fortinet_fortigate - 1.26.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue and removed bug Something isn't working, use only for issues labels Oct 28, 2024
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@gogochan
[Fortinet Fortigate] swap source and destination for fortigate VPN ev…
28365c9 
…ent (elastic#11523)
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@gogochan
[Fortinet Fortigate] swap source and destination for fortigate VPN ev…
9d5cd45 
…ent (elastic#11523)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

5 participants

@gogochan @elasticmachine @taylor-swanson @andrewkroh