Skip to content

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Oct 23, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request bugfix Pull request that fixes a bug issue Integration:wiz Wiz Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Oct 23, 2024
@efd6 efd6 self-assigned this Oct 23, 2024
Comment on lines +106 to +107
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really be a match_only_text, but the other fields here, control_description and resolution_recommendation should also, so maintaining alignment and not breaking things by fixing those fields.

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💔 Build #17468 failed e3e8fac69adb1cb373a998df983a11e28ef3fc18

cc @efd6

@efd6 efd6 marked this pull request as ready for review October 23, 2024 01:46
@efd6 efd6 requested a review from a team as a code owner October 23, 2024 01:46
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 merged commit d1ac4ef into elastic:main Oct 23, 2024
5 checks passed
@elastic-vault-github-plugin-prod

Package wiz - 1.9.0-preview07 containing this change is available at https://epr.elastic.co/search?package=wiz

@elastic-vault-github-plugin-prod

Package wiz - 2.0.0 containing this change is available at https://epr.elastic.co/search?package=wiz

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@efd6 efd6 deleted the s5298-wiz branch February 5, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue enhancement New feature or request Integration:wiz Wiz Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants