[aws_bedrock] Ignore non-policy data under ...trace.guardrail #11487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
chrisberkhout added bugfix 
| Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
chrisberkhout changed the title 
efd6 approved these changes Oct 22, 2024
5 tasks
🚀 Benchmarks reportTo see the full report comment with |
|
💚 Build Succeeded
History
|
| Package aws_bedrock - 0.11.3 containing this change is available at https://epr.elastic.co/search?package=aws_bedrock |
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…c#11487) In existing pipeline tests, input documents only had policy data under `output.outputBodyJson.trace.guardrail.inputAssessment`, but now there is also `invocationMetrics` data. This change modifies the `get_guardrail_details` script to skip entries that don't have policy at the end of their name. It also adds cases to be processed in the `painless_to_rename_fields_under_aws_bedrock_groups` script, so that in the output, the naming of the new invocation metrics object matches the surrounding data. --------- Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…c#11487) In existing pipeline tests, input documents only had policy data under `output.outputBodyJson.trace.guardrail.inputAssessment`, but now there is also `invocationMetrics` data. This change modifies the `get_guardrail_details` script to skip entries that don't have policy at the end of their name. It also adds cases to be processed in the `painless_to_rename_fields_under_aws_bedrock_groups` script, so that in the output, the naming of the new invocation metrics object matches the surrounding data. --------- Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Discussion
Existing pipeline tests had input documents with values under
output.outputBodyJson.trace.guardrail.inputAssessmentsuch as:{ "l7n9e426howe": { "topicPolicy": { "topics": [ { "name": "Robbing A Bank", "type": "DENY", "action": "BLOCKED" } ] }, "contentPolicy": { "filters": [ { "type": "MISCONDUCT", "confidence": "HIGH", "action": "BLOCKED" } ] } } }Now this has been observed:
{ "l4n3ea14nowf": { "contentPolicy": { "filters": [ { "type": "PROMPT_ATTACK", "confidence": "HIGH", "filterStrength": "HIGH", "action": "BLOCKED" } ] }, "invocationMetrics": { "guardrailProcessingLatency": 340, "usage": { "topicPolicyUnits": 0, "contentPolicyUnits": 1, "wordPolicyUnits": 0, "sensitiveInformationPolicyUnits": 0, "sensitiveInformationPolicyFreeUnits": 0, "contextualGroundingPolicyUnits": 0 }, "guardrailCoverage": { "textCharacters": { "guarded": 73, "total": 74 } } } } }I chose to only process objects with keys ending in
Policy(_policyafter the renaming).Checklist
changelog.ymlfile.How to test this PR locally
The change is covered by a modified pipeline test.
Related issues