[AWS] Add support to configure owning account for AWS metrics integrations #11442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Kavindu-Dodan added enhancement Kavindu-Dodan force-pushed the feat/aws-owning-account-for-metrics branch from 1c32b57 to ab4e0ea Compare 
andrewkroh added Integration:aws 
| Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
Contributor Author
| @kaiyan-sheng the latest version works end to end without any issue. This commit 71a3190 fixed the integer conversation issue. |
Kavindu-Dodan force-pushed the feat/aws-owning-account-for-metrics branch 2 times, most recently from dd5ee44 to 764fa85 Compare Contributor
kaiyan-sheng left a comment
kaiyan-sheng left a comment There was a problem hiding this comment.
It will be good to also add this new config in to aws_bedrock package :)
Contributor Author
ohh thanks for noticing this. I will add this :) |
Kavindu-Dodan force-pushed the feat/aws-owning-account-for-metrics branch from deb7c4f to 59e1f27 Compare Contributor Author
@kaiyan-sheng done, added with commit 59e1f27 |
efd6 approved these changes Oct 20, 2024
Contributor
efd6 left a comment
efd6 left a comment There was a problem hiding this comment.
codeowner approval only (with nit)
Kavindu-Dodan force-pushed the feat/aws-owning-account-for-metrics branch 2 times, most recently from a2f5a97 to 8a28151 Compare 
agithomas reviewed Oct 22, 2024
Contributor
| Could you check if the aws_bedrock package also must receive this change? |
agithomas reviewed Oct 22, 2024
Contributor Author
Yeah, this is already included in the aws_bedrock integration - https://github.com/elastic/integrations/pull/11442/files#diff-c926417996626708e4db868273667118a2e9edb1fde0d50858531be8dc780c73 |
Kavindu-Dodan force-pushed the feat/aws-owning-account-for-metrics branch from 243d43b to d7bfba4 Compare 
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> # Conflicts: # packages/aws/changelog.yml
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> # Conflicts: # packages/aws_bedrock/changelog.yml
Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Kavindu-Dodan force-pushed the feat/aws-owning-account-for-metrics branch from d7bfba4 to 4ca5449 Compare 
kaiyan-sheng approved these changes Oct 22, 2024
💚 Build Succeeded
History
|
|
| Package aws - 2.30.0 containing this change is available at https://epr.elastic.co/search?package=aws |
| Package aws_bedrock - 0.12.0 containing this change is available at https://epr.elastic.co/search?package=aws_bedrock |
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…tions (elastic#11442) * introduce owning account for AWS metrics integrations Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> # Conflicts: # packages/aws/changelog.yml * update build docs Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * update compatible beats version Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * add missing property to agent Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * accept owning account as a string at agent Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * fix merge conflict and update changelog and version Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * make ownining account conditional Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * add ownining account support to aws bedrock Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> # Conflicts: # packages/aws_bedrock/changelog.yml * Update packages/aws/_dev/build/docs/README.md Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> * Update packages/aws/_dev/build/docs/README.md Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> * set 0.12.0 version for aws bedrock Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * add newline Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * update build docs Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * review suggestion - links to aws resources Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> --------- Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…tions (elastic#11442) * introduce owning account for AWS metrics integrations Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> # Conflicts: # packages/aws/changelog.yml * update build docs Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * update compatible beats version Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * add missing property to agent Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * accept owning account as a string at agent Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * fix merge conflict and update changelog and version Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * make ownining account conditional Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * add ownining account support to aws bedrock Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> # Conflicts: # packages/aws_bedrock/changelog.yml * Update packages/aws/_dev/build/docs/README.md Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> * Update packages/aws/_dev/build/docs/README.md Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> * set 0.12.0 version for aws bedrock Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * add newline Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * update build docs Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * review suggestion - links to aws resources Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> --------- Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR adds support to configure Owning Account for AWS metrics integrations. The Owning Account property works together with Include Linked Accounts property. And it accepts an AWS account ID which should be a valid linked account ID of the monitoring account.
Checklist
changelog.ymlfile.Related issues
Screenshots