Skip to content

Conversation

@clement-fouque
Copy link
Contributor

@clement-fouque clement-fouque commented Sep 11, 2024

…ection.vulnerability.qds_factors`

Proposed commit message

In this version 5.1.0, the following changes have been made:

  • Set vulnerability.score.base field based on the item CVSS item under field qualys_vmdr.asset_host_detection.vulnerability.qds_factors
  • Set vulnerability.classification field to CVSS
  • Set vulnerability.severity field based on vulnerability.score.base
  • Set vulnerability.scanner.vendor field to Qualys
  • Set vulnerability.score.version field based on the item CVSS_vector item under field qualys_vmdr.asset_host_detection.vulnerability.qds_factors

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@andrewkroh andrewkroh added the enhancement New feature or request label Sep 11, 2024
@clement-fouque clement-fouque marked this pull request as ready for review September 11, 2024 16:13
@clement-fouque clement-fouque requested a review from a team as a code owner September 11, 2024 16:13
@clement-fouque
Copy link
Contributor Author

The build is failing but it's passing on my laptop. Based on the logs, I'm not sure it's linked to my work. Do you have an idea on the root cause?

@andrewkroh andrewkroh added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Sep 11, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@andrewkroh
Copy link
Member

@@ -209,2 +209,3 @@ "vulnerability": { + "classification": "CVSS", "scanner": { Error: checking package failed: checking readme files are up-to-date failed: files do not match 
@elasticmachine
Copy link

elasticmachine commented Sep 11, 2024

🚀 Benchmarks report

Package qualys_vmdr 👍(0) 💚(0) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
asset_host_detection 1277.14 719.42 -557.72 (-43.67%) 💔
knowledge_base 1886.79 1483.68 -403.11 (-21.36%) 💔
user_activity 9090.91 7042.25 -2048.66 (-22.54%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

@clement-fouque
Copy link
Contributor Author

I've implemented @efd6's suggestion. I believe it's ready to be merged.

@clement-fouque clement-fouque merged commit 1664d36 into main Sep 16, 2024
@clement-fouque clement-fouque deleted the qualys_vmdr-5_1_0 branch September 16, 2024 06:48
@elasticmachine
Copy link

Package qualys_vmdr - 5.1.0 containing this change is available at https://epr.elastic.co/search?package=qualys_vmdr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:qualys_vmdr Qualys VMDR Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

5 participants