Skip to content

Conversation

@janvi-elastic
Copy link
Contributor

Type of change

  • Bug

Proposed commit message

  • Fix null check conditions

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/symantec_endpoint_security directory.
  • Run the following command to run tests.

elastic-package test

Run pipeline tests for the package --- Test results for package: symantec_endpoint_security - START --- ╭────────────────────────────┬─────────────┬───────────┬──────────────────────────────────────────────────────────┬────────┬──────────────╮ │ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │ TIME ELAPSED │ ├────────────────────────────┼─────────────┼───────────┼──────────────────────────────────────────────────────────┼────────┼──────────────┤ │ symantec_endpoint_security │ event │ pipeline │ (ingest pipeline warnings test-category-application.log) │ PASS │ 372.132004ms │ │ symantec_endpoint_security │ event │ pipeline │ (ingest pipeline warnings test-category-audit.log) │ PASS │ 351.122969ms │ │ symantec_endpoint_security │ event │ pipeline │ (ingest pipeline warnings test-category-diagnostic.log) │ PASS │ 378.266797ms │ │ symantec_endpoint_security │ event │ pipeline │ (ingest pipeline warnings test-category-license.log) │ PASS │ 363.981172ms │ │ symantec_endpoint_security │ event │ pipeline │ (ingest pipeline warnings test-category-security.log) │ PASS │ 371.362778ms │ │ symantec_endpoint_security │ event │ pipeline │ (ingest pipeline warnings test-category-system.log) │ PASS │ 366.003388ms │ │ symantec_endpoint_security │ event │ pipeline │ (ingest pipeline warnings test-scalar-flattened.log) │ PASS │ 384.112974ms │ │ symantec_endpoint_security │ event │ pipeline │ test-category-application.log │ PASS │ 3.403192917s │ │ symantec_endpoint_security │ event │ pipeline │ test-category-audit.log │ PASS │ 1.233035227s │ │ symantec_endpoint_security │ event │ pipeline │ test-category-diagnostic.log │ PASS │ 1.264094352s │ │ symantec_endpoint_security │ event │ pipeline │ test-category-license.log │ PASS │ 827.763136ms │ │ symantec_endpoint_security │ event │ pipeline │ test-category-security.log │ PASS │ 9.109224708s │ │ symantec_endpoint_security │ event │ pipeline │ test-category-system.log │ PASS │ 7.462712857s │ │ symantec_endpoint_security │ event │ pipeline │ test-scalar-flattened.log │ PASS │ 313.150181ms │ │ symantec_endpoint_security │ incident │ pipeline │ (ingest pipeline warnings test-incident.log) │ PASS │ 365.160305ms │ │ symantec_endpoint_security │ incident │ pipeline │ test-incident.log │ PASS │ 125.794342ms │ ╰────────────────────────────┴─────────────┴───────────┴──────────────────────────────────────────────────────────┴────────┴──────────────╯ --- Test results for package: symantec_endpoint_security - END --- Done 
@janvi-elastic janvi-elastic requested a review from a team as a code owner September 6, 2024 13:14
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Crest Contributions from Crest developement team. Integration:symantec_endpoint_security Symantec Endpoint Security Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Sep 6, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6
Copy link
Contributor

efd6 commented Sep 8, 2024

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

@efd6 efd6 merged commit ca0cfc0 into elastic:main Sep 8, 2024
@elasticmachine
Copy link

Package symantec_endpoint_security - 0.3.2 containing this change is available at https://epr.elastic.co/search?package=symantec_endpoint_security

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
A number of field references unsafely included access through potentially null objects, so add null-safe operators.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
A number of field references unsafely included access through potentially null objects, so add null-safe operators.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Crest Contributions from Crest developement team. Integration:symantec_endpoint_security Symantec Endpoint Security Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants