Skip to content

entityanalytics_ad: expose attribute selection configuration #10955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2024
Merged

entityanalytics_ad: expose attribute selection configuration #10955

merged 1 commit into from
Nov 21, 2024

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Sep 2, 2024

DEPENDS STACK v8.16.0

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:entityanalytics_ad Active Directory Entity Analytics labels Sep 2, 2024
@efd6 efd6 self-assigned this Sep 2, 2024
@efd6 efd6 force-pushed the 10952-entityanalytics_ad branch 3 times, most recently from 7a9e068 to 28b038d Compare September 4, 2024 01:26
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@efd6 efd6 force-pushed the 10952-entityanalytics_ad branch from 28b038d to b2b94b3 Compare October 3, 2024 04:01
@elastic-sonarqube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube
@botelastic
Copy link

botelastic bot commented Nov 2, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!
@botelastic botelastic bot added the Stalled label Nov 2, 2024
@efd6 efd6 removed the Stalled label Nov 3, 2024
@efd6 efd6 force-pushed the 10952-entityanalytics_ad branch from b2b94b3 to 0602106 Compare November 3, 2024 23:16
@elastic-sonarqube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube
@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #16747 succeeded b2b94b3e18d1ca975f0e879ce68e27d15b8ba938
  • 💚 Build #15423 succeeded 28b038dc2724965e3ac580b98e91de41554dd07a
  • 💚 Build #15283 succeeded 09e6069ab8ecfa60d6881a5e3d70963cef8523ff

cc @efd6
@nicpenning
Copy link
Contributor

👀
@efd6 efd6 marked this pull request as ready for review November 12, 2024 21:57
@efd6 efd6 requested a review from a team as a code owner November 12, 2024 21:57
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
kcreddy
kcreddy approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion, LGTM otherwise.
@efd6 efd6 requested a review from kcreddy November 20, 2024 21:12
@efd6 efd6 merged commit a470d85 into elastic:main Nov 21, 2024
4 of 5 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package entityanalytics_ad - 0.4.0 containing this change is available at https://epr.elastic.co/package/entityanalytics_ad/0.4.0/
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
@efd6 @flexitrev
entityanalytics_ad: expose attribute selection configuration (#10955)
6a6c101
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@efd6
entityanalytics_ad: expose attribute selection configuration (elastic…
747e1cc 
…#10955)
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@efd6 @flexitrev
entityanalytics_ad: expose attribute selection configuration (#10955)
f083869
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@efd6
entityanalytics_ad: expose attribute selection configuration (elastic…
54fd168 
…#10955)
@efd6 efd6 deleted the 10952-entityanalytics_ad branch February 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:entityanalytics_ad Active Directory Entity Analytics Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants

@efd6 @elasticmachine @nicpenning @kcreddy