Skip to content

Conversation

@brijesh-elastic
Copy link
Collaborator

Type of change

  • Enhancement

Proposed commit message

Update the pagination termination condition for the threat data stream so that pagination stops whenever nextPageNumber is not found in the response body. This should apply to both the /v1/threats and /v1/threats/:id endpoints.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/abnormal_security directory.
  • Run the following command to run tests.

elastic-package test

@brijesh-elastic brijesh-elastic requested a review from a team as a code owner August 23, 2024 09:59
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

@andrewkroh andrewkroh added Crest Contributions from Crest developement team. enhancement New feature or request Integration:abnormal_security Abnormal AI Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Aug 23, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kcreddy kcreddy merged commit c577fbb into elastic:main Aug 27, 2024
@elasticmachine
Copy link

Package abnormal_security - 0.1.1 containing this change is available at https://epr.elastic.co/search?package=abnormal_security

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…10860) Update the pagination termination condition for the threat data stream so that pagination stops whenever nextPageNumber is not found in the response body. This should apply to both the /v1/threats and /v1/threats/:id endpoints.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…10860) Update the pagination termination condition for the threat data stream so that pagination stops whenever nextPageNumber is not found in the response body. This should apply to both the /v1/threats and /v1/threats/:id endpoints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Crest Contributions from Crest developement team. enhancement New feature or request Integration:abnormal_security Abnormal AI Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants