Skip to content

Conversation

@mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Aug 9, 2024

Proposed commit message

Log messages could contain empty user name strings. This updates message parsing for message ID 113005, 716002, 713049 to handle empty user names.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
Log messages could contain empty user name strings. This updates message parsing for message ID 113005, 716002 to handle empty user names.
@mjwolf mjwolf added the bugfix Pull request that fixes a bug issue label Aug 9, 2024
@mjwolf mjwolf requested a review from a team as a code owner August 9, 2024 21:38
@mjwolf mjwolf self-assigned this Aug 9, 2024
@andrewkroh andrewkroh added Integration:cisco_asa Cisco ASA Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Aug 9, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elasticmachine
Copy link

elasticmachine commented Aug 9, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@mjwolf mjwolf enabled auto-merge (squash) August 9, 2024 23:58
@mjwolf mjwolf force-pushed the cisco_asa_empty_usernames branch from 701a8ad to 5d48503 Compare August 12, 2024 19:34
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @mjwolf

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjwolf mjwolf merged commit 54cc01f into elastic:main Aug 14, 2024
@elasticmachine
Copy link

Package cisco_asa - 2.36.3 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
Log messages could contain empty user name strings. This updates message parsing for message ID 113005, 716002 to handle empty user names.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
Log messages could contain empty user name strings. This updates message parsing for message ID 113005, 716002 to handle empty user names.
@mjwolf mjwolf deleted the cisco_asa_empty_usernames branch February 5, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cisco_asa Cisco ASA Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

5 participants