Skip to content

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Jul 31, 2024

Proposed commit message

This adds a UI configurator that allows the user to select which of the two sources (or both) to use to populate the cloud fields. It also tags the document with an indicator of which sources were available.


It's quite extravagant, so I'm not sure of the merits of merging this, but is was what was asked for as the ideal. So here it is.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

qualys_vmdr-cloud-field-selector
@efd6 efd6 added enhancement New feature or request Integration:qualys_vmdr Qualys VMDR Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jul 31, 2024
@efd6 efd6 self-assigned this Jul 31, 2024
@efd6 efd6 force-pushed the 10277-qualys_vmdr-config branch from e9fc680 to 4153080 Compare July 31, 2024 09:10
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review July 31, 2024 10:36
@efd6 efd6 requested a review from a team as a code owner July 31, 2024 10:36
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 requested a review from clement-fouque August 1, 2024 00:22
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor clarification

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this text be just Provider instead of Provider Provider

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It should be "Provider Only".

@efd6
Copy link
Contributor Author

efd6 commented Aug 2, 2024

Waiting for @clement-fouque.

@efd6 efd6 force-pushed the 10277-qualys_vmdr-config branch from 16216f3 to 1e270c1 Compare August 6, 2024 00:05
@andrewkroh
Copy link
Member

fyi: I added a screenshot to the description showing the new configuration option in the UI. The default value is selected.

Figured this would be useful to @clement-fouque.

efd6 added 2 commits August 13, 2024 07:29
This adds a UI configurator that allows the user to select which of the two sources (or both) to use to populate the cloud fields. It also tags the document with an indicator of which sources were available.
@efd6 efd6 force-pushed the 10277-qualys_vmdr-config branch from 1e270c1 to 02b7b29 Compare August 12, 2024 22:00
@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #14319 succeeded 1e270c13bd71c454edfbe30891d711e0f2637993
  • 💚 Build #14248 succeeded 16216f392b3c59f6f4d115a0e09c8b935d26293a
  • 💚 Build #14165 succeeded 4153080094d976599807e13a9e4c2656bef5a6f1

cc @efd6

@efd6 efd6 merged commit dab6e12 into elastic:main Aug 14, 2024
@efd6
Copy link
Contributor Author

efd6 commented Aug 14, 2024

Discussed with @clement-fouque offline.

@elasticmachine
Copy link

Package qualys_vmdr - 4.3.0 containing this change is available at https://epr.elastic.co/search?package=qualys_vmdr

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…lastic#10658) This adds a UI configurator that allows the user to select which of the two sources (or both) to use to populate the cloud fields. It also tags the document with an indicator of which sources were available.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…lastic#10658) This adds a UI configurator that allows the user to select which of the two sources (or both) to use to populate the cloud fields. It also tags the document with an indicator of which sources were available.
@efd6 efd6 deleted the 10277-qualys_vmdr-config branch February 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:qualys_vmdr Qualys VMDR Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants