- Notifications
You must be signed in to change notification settings - Fork 518
[abnormal_security] Initial release of the Abnormal Security #10653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
packages/abnormal_security/data_stream/ai_security_mailbox/agent/stream/cel.yml.hbs Outdated Show resolved Hide resolved
packages/abnormal_security/data_stream/ai_security_mailbox/agent/stream/cel.yml.hbs Outdated Show resolved Hide resolved
packages/abnormal_security/data_stream/ai_security_mailbox/fields/base-fields.yml Outdated Show resolved Hide resolved
packages/abnormal_security/data_stream/ai_security_mailbox/fields/beats.yml Outdated Show resolved Hide resolved
| "https://example.com", | ||
| "https://example.com", | ||
| "https://example.com", | ||
| "https://example.com", | ||
| "https://example.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing that these would not all be duplicates in real data. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it will be unique in real data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be an array. https://www.elastic.co/guide/en/ecs/current/ecs-url.html#field-url-original.
Better not copy array urls into url.original
packages/abnormal_security/data_stream/threat/agent/stream/cel.yml.hbs Outdated Show resolved Hide resolved
packages/abnormal_security/data_stream/threat/fields/base-fields.yml Outdated Show resolved Hide resolved
packages/abnormal_security/data_stream/threat/_dev/test/pipeline/test-threat.log-expected.json Outdated Show resolved Hide resolved
packages/abnormal_security/data_stream/threat/_dev/test/pipeline/test-threat.log-expected.json Outdated Show resolved Hide resolved
packages/abnormal_security/data_stream/threat/_dev/test/pipeline/test-threat.log-expected.json Outdated Show resolved Hide resolved
packages/abnormal_security/data_stream/threat/_dev/test/pipeline/test-threat.log-expected.json Show resolved Hide resolved
| "https://example.com", | ||
| "https://example.com", | ||
| "https://example.com", | ||
| "https://example.com", | ||
| "https://example.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be an array. https://www.elastic.co/guide/en/ecs/current/ecs-url.html#field-url-original.
Better not copy array urls into url.original
| "abnormal_security-audit" | ||
| ], | ||
| "url": { | ||
| "extension": "1/messages/email_content/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you apply similar change to this one: #9623 for all datastream's pipeline test config which use uri_parts?
The pipeline test config temporarily fixes issue with url.extension having flaky tests in versions 8.14+.
...ata_stream/ai_security_mailbox/_dev/test/pipeline/test-ai-security-mailbox.log-expected.json Outdated Show resolved Hide resolved
...ata_stream/ai_security_mailbox/_dev/test/pipeline/test-ai-security-mailbox.log-expected.json Outdated Show resolved Hide resolved
...ata_stream/ai_security_mailbox/_dev/test/pipeline/test-ai-security-mailbox.log-expected.json Show resolved Hide resolved
kcreddy left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Can be merged after @efd6 approval. Thanks!
efd6 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one outstanding issue.
| "code": string(resp.StatusCode), | ||
| "id": string(resp.Status), | ||
| "message": "GET:"+( | ||
| size(resp.Body) != 0 ? | ||
| string(resp.Body) | ||
| : | ||
| string(resp.Status) + ' (' + string(resp.StatusCode) + ')' | ||
| ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not done.
packages/abnormal_security/data_stream/ai_security_mailbox/agent/stream/cel.yml.hbs Outdated Show resolved Hide resolved
efd6 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
💚 Build Succeeded
History
|
| Package abnormal_security - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=abnormal_security |
…#10653) * Added ai_security_mailbox, audit, case and threat data stream. * Added data collection logic for all the data stream. * Added the ingest pipeline for all the data stream. * Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files. * Added dashboards and visualizations. * Added test for pipeline for all the data stream. * Added system test cases for all the data stream.
…#10653) * Added ai_security_mailbox, audit, case and threat data stream. * Added data collection logic for all the data stream. * Added the ingest pipeline for all the data stream. * Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files. * Added dashboards and visualizations. * Added test for pipeline for all the data stream. * Added system test cases for all the data stream.




Proposed commit message
Create New integration package abnormal_security.
Checklist
changelog.ymlfile.How to test this PR locally
Related issues
Screenshots