Skip to content

Conversation

@jrmolin
Copy link
Contributor

@jrmolin jrmolin commented Jul 24, 2024

Proposed commit message

[cisco asa] Message 716059 has new format

  • Add new grok patterns to capture the new message structure
  • Verify no regressions

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

cd packages/cisco_asa elastic-package test 

Related issues

Screenshots

@jrmolin jrmolin added the bugfix Pull request that fixes a bug issue label Jul 24, 2024
@jrmolin jrmolin self-assigned this Jul 24, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@jrmolin jrmolin marked this pull request as ready for review July 24, 2024 15:49
@jrmolin jrmolin requested a review from a team as a code owner July 24, 2024 15:49
@andrewkroh andrewkroh added Integration:cisco_asa Cisco ASA Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Jul 24, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@taylor-swanson
Copy link
Contributor

taylor-swanson commented Jul 24, 2024

Title nit: I don't think we should mention SDH in the public integrations repo, it's not going to mean anything to anyone else. We can link the SDH issue in the description under the related issues are and that'll be good enough I think.

Something like this is fine:

[cisco_asa] Message 716059 alternative format

I generally follow the format of:

[integration] Short description of change

@jrmolin jrmolin changed the title SDH4848 - Cisco ASA message 716059 alternative format [Cisco ASA] message 716059 alternative format Jul 25, 2024
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @jrmolin

@pkoutsovasilis pkoutsovasilis merged commit 48db162 into elastic:main Jul 25, 2024
@elasticmachine
Copy link

Package cisco_asa - 2.36.2 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
* update a pattern to capture an alternate message/log format * add pr link * update tests and patterns to reflect actual customer data * accept suggestions from PR * feat: merge groks for parsing 716059 --------- Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cisco_asa Cisco ASA Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

5 participants