Skip to content

[cisco_asa] Add new log types #10340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
taylor-swanson merged 3 commits into from
Jul 3, 2024
Merged

[cisco_asa] Add new log types #10340

taylor-swanson merged 3 commits into from
Jul 3, 2024

Conversation

@taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Jul 2, 2024 •
edited
Loading

Proposed commit message

  • Add support for 111007, 113022, 113023, 425005, 611103 logs
  • Add tests

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/cisco_asa elastic-package test

Related issues
@taylor-swanson taylor-swanson added enhancement New feature or request Integration:cisco_asa Cisco ASA Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Jul 2, 2024
@taylor-swanson taylor-swanson self-assigned this Jul 2, 2024
@taylor-swanson
[cisco_asa] Add new log types
84a77c7 
- Add support for 111007, 113022, 113023, 425005, 611103 logs - Add tests
@taylor-swanson
use source instead of destination
57611c5
@taylor-swanson
regen readme
50707db
@elasticmachine
Copy link

elasticmachine commented Jul 2, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elasticmachine
Copy link

elasticmachine commented Jul 2, 2024

💚 Build Succeeded

History

cc @taylor-swanson
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Jul 2, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@taylor-swanson taylor-swanson marked this pull request as ready for review July 2, 2024 20:48
@taylor-swanson taylor-swanson requested a review from a team as a code owner July 2, 2024 20:48
@elasticmachine
Copy link

elasticmachine commented Jul 2, 2024

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)
pkoutsovasilis
pkoutsovasilis approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@taylor-swanson taylor-swanson merged commit f0e20a4 into elastic:main Jul 3, 2024
@taylor-swanson taylor-swanson deleted the enhance/asa-new-logs branch July 3, 2024 12:59
@elasticmachine
Copy link

elasticmachine commented Jul 3, 2024

Package cisco_asa - 2.36.0 containing this change is available at https://epr.elastic.co/search?package=cisco_asa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cisco_asa Cisco ASA Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

3 participants

@taylor-swanson @elasticmachine @pkoutsovasilis