Skip to content

New Integration Gigamon #10268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2024
Merged

New Integration Gigamon #10268

merged 2 commits into from
Aug 23, 2024

Conversation

@anupratharamachandran
Copy link
Contributor

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@cla-checker-service
Copy link

cla-checker-service bot commented Jun 26, 2024 •
edited
Loading

💚 CLA has been signed
@kcreddy kcreddy changed the title PR request for Gigamon Integrations New Integration Gigamon Jun 26, 2024
@kcreddy kcreddy marked this pull request as draft June 26, 2024 12:43
@kcreddy
Copy link
Contributor

kcreddy commented Jun 26, 2024

Moved to draft until the issue with dashboards (errors inside exported dashboards) is resolved.
@kcreddy kcreddy marked this pull request as ready for review July 1, 2024 07:51
@kcreddy kcreddy added the New Integration Issue or pull request for creating a new integration package. label Jul 1, 2024
@kcreddy
Copy link
Contributor

kcreddy commented Jul 1, 2024

/test
kcreddy
kcreddy reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integration doesn't have ECS mappings applied yet. This is a major enhancement to be made in upcoming release.
@kcreddy
Copy link
Contributor

kcreddy commented Jul 1, 2024

@anupratharamachandran The CI is currently failing because there should be a line added in .github/CODEOWNERS file.
So, please add this below line to .github/CODEOWNERS file:
/packages/gigamon @elastic/security-service-integrations

Add it above this line: https://github.com/elastic/integrations/blob/main/.github/CODEOWNERS#L195 to preserve alphabetical ordering.
@kcreddy kcreddy added Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Partner labels Jul 1, 2024
@kcreddy
Copy link
Contributor

kcreddy commented Jul 4, 2024

/test
kcreddy
kcreddy reviewed Jul 4, 2024
View reviewed changes
packages/gigamon/data_stream/ami/manifest.yml Outdated
Comment on lines 64 to 67
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still stands.
@kcreddy
Copy link
Contributor

kcreddy commented Jul 12, 2024

/test
@elastic-sonarqube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
53.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube
kcreddy
kcreddy reviewed Jul 12, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing because tests are not successful.
Can you check if you have pipeline and also system tests successful on your side?

Pipeline: eval "$(elastic-package stack shellinit)" && elastic-package test pipeline --generate -v
System: eval "$(elastic-package stack shellinit)" && elastic-package test system --generate -v
packages/gigamon/_dev/build/docs/README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point 3.
Screenshot 2024-07-12 at 3 59 36 PM

This section is not indented properly. Can you indent below lines until point number 4.

We could also make the property and its description like below, so users can follow the instructions better.

- **Alias**: Enter the alias name for the cloud tool export.

Example: https://github.com/elastic/integrations/blob/main/packages/infoblox_bloxone_ddi/_dev/build/docs/README.md?plain=1#L31-L32
@kcreddy
Copy link
Contributor

kcreddy commented Aug 22, 2024

/test
kcreddy
kcreddy reviewed Aug 22, 2024
View reviewed changes
@kcreddy
Copy link
Contributor

kcreddy commented Aug 23, 2024

/test
@kcreddy
Copy link
Contributor

kcreddy commented Aug 23, 2024

/test
@kcreddy
Copy link
Contributor

kcreddy commented Aug 23, 2024

/test
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💔 Build #14961 failed 02f7b0924ecd8a68e343a991e68ced6dbbdbdc1e
  • 💔 Build #14953 failed 1f17404f17c4fa677d74c67e18b563f14a8aa1cc
  • 💔 Build #14885 failed e027a1efab1271c38d404b89435cc71e41845efe
  • 💔 Build #13602 failed f820d36c264d12eaf927ba249a997c28b9076877
  • 💔 Build #13231 failed 15c35c4f646989acee3d520e9586d67c0f5c6295
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
98.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
kcreddy
kcreddy approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Thanks @anupratharamachandran
@kcreddy kcreddy merged commit c408f13 into elastic:main Aug 23, 2024
@anupratharamachandran
Copy link
Contributor Author

Thanks much @kcreddy . Really appreciate your support🙌
@andrewkroh andrewkroh added the Integration:gigamon Gigamon (Partner supported) label Aug 23, 2024
@elasticmachine
Copy link

Package gigamon - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=gigamon
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@anupratharamachandran
New Integration Gigamon (elastic#10268)
8d81895 
New Integration Gigamon
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@anupratharamachandran
New Integration Gigamon (elastic#10268)
ea2628a 
New Integration Gigamon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:gigamon Gigamon (Partner supported) New Integration Issue or pull request for creating a new integration package. Partner Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants

@anupratharamachandran @kcreddy @elasticmachine @andrewkroh