Skip to content

Conversation

@peterydzynski
Copy link
Contributor

Proposed commit message

There are rare cases where a Zeek log has a "network.transport" of "tcp" but the source and destination port values are 0 which breaks the community_id processor as it requires a non zero value in both port fields. This appears to happen when the "zeek.connection.history" is just "R" but otherwise I cannot explain why this happens. Since this pipeline calls the custom Zeek Connection pipeline, failure at this stage means that the custom pipelines are never called.

To fix this I added a check on the community_id processor in the Zeek connection pipeline to ensure source and destination port are not 0.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

image

@peterydzynski peterydzynski requested a review from a team as a code owner June 20, 2024 19:46
@andrewkroh andrewkroh added Integration:zeek Zeek Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Jun 24, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterydzynski please do the following:

  • please add a log entry in this file that captures what you describe in the issue and then following these guidelines run the pipeline test
  • update the changelog and the manifest accordingly
@peterydzynski
Copy link
Contributor Author

@pkoutsovasilis Let me know if those updates are what you're looking for!

@pkoutsovasilis
Copy link
Contributor

/test

@elasticmachine
Copy link

🚀 Benchmarks report

Package zeek 👍(37) 💚(2) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
mysql 30303.03 10638.3 -19664.73 (-64.89%) 💔
pe 26315.79 14925.37 -11390.42 (-43.28%) 💔
smb_mapping 30303.03 23255.81 -7047.22 (-23.26%) 💔
dce_rpc 24390.24 13513.51 -10876.73 (-44.59%) 💔

To see the full report comment with /test benchmark fullreport

@peterydzynski
Copy link
Contributor Author

🚀 Benchmarks report

Package zeek 👍(37) 💚(2) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
mysql30303.03 10638.3 -19664.73 (-64.89%) 💔
pe26315.79 14925.37 -11390.42 (-43.28%) 💔
smb_mapping30303.03 23255.81 -7047.22 (-23.26%) 💔
dce_rpc24390.24 13513.51 -10876.73 (-44.59%) 💔
To see the full report comment with /test benchmark fullreport

@pkoutsovasilis Is the EPS diff something to be concerned about?

@pkoutsovasilis
Copy link
Contributor

@pkoutsovasilis Is the EPS diff something to be concerned about?

I think that it is just a hiccup but let me invoke the testing one more time just to be sure

@pkoutsovasilis
Copy link
Contributor

/test

@peterydzynski
Copy link
Contributor Author

@pkoutsovasilis i dont see the new test results, did they get published yet?

@pkoutsovasilis
Copy link
Contributor

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterydzynski
Copy link
Contributor Author

@pkoutsovasilis sorry to keep pinging but really need this bugfix to get deployed. can we get this merged in please?

@taylor-swanson taylor-swanson merged commit 2bb8b16 into elastic:main Aug 7, 2024
@taylor-swanson
Copy link
Contributor

@peterydzynski, @pkoutsovasilis is out this week, but I went ahead and merged the fix.

@elasticmachine
Copy link

Package zeek - 2.24.2 containing this change is available at https://epr.elastic.co/search?package=zeek

@peterydzynski
Copy link
Contributor Author

Thank you so much!

@peterydzynski peterydzynski deleted the zeek-community-id-port-bug branch August 7, 2024 14:27
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…lastic#10205) - Added a check on the community_id processor in the Zeek connection pipeline to ensure source and destination port are not 0.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…lastic#10205) - Added a check on the community_id processor in the Zeek connection pipeline to ensure source and destination port are not 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:zeek Zeek Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

5 participants