Skip to content

[winlog] Preserve original event when toggled on #10198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 25, 2024
Merged

[winlog] Preserve original event when toggled on #10198

merged 9 commits into from
Jun 25, 2024

Conversation

@nicpenning
Copy link
Contributor

@nicpenning nicpenning commented Jun 20, 2024 •
edited
Loading

  • Bug

Proposed commit message

See title.

This should resolve the winlog issue here: #9425

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

image
@nicpenning nicpenning requested review from a team as code owners June 20, 2024 02:48
@nicpenning
Copy link
Contributor Author

nicpenning commented Jun 20, 2024

Need to split this PR for only winlog.
@nicpenning nicpenning closed this Jun 20, 2024
@nicpenning nicpenning reopened this Jun 21, 2024
@nicpenning
Copy link
Contributor Author

nicpenning commented Jun 21, 2024

Clean up commits and added screenshot. Ready for tests!
@nicpenning nicpenning mentioned this pull request Jun 21, 2024
Merged
4 tasks
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] label Jun 21, 2024
@elasticmachine
Copy link

elasticmachine commented Jun 21, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)
@pierrehilbert pierrehilbert added the Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform] label Jun 24, 2024
@elasticmachine
Copy link

elasticmachine commented Jun 24, 2024

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)
@marc-gr
Copy link
Contributor

marc-gr commented Jun 25, 2024

/test
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Jun 25, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube
@elasticmachine
Copy link

elasticmachine commented Jun 25, 2024

💚 Build Succeeded
@marc-gr marc-gr merged commit fbd3946 into elastic:main Jun 25, 2024
@nicpenning
Copy link
Contributor Author

nicpenning commented Jun 25, 2024

Thank you!
@nicpenning
Copy link
Contributor Author

nicpenning commented Jun 25, 2024 •
edited
Loading

Looks like we all missed the PR number in the changelog. Should that just get changed on the next update or should I do a quick PR with updating that changelog and not increment the changelog version number? (10198)

Fix here: #10246
@andrewkroh andrewkroh added the Integration:winlog Custom Windows Event Logs label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:winlog Custom Windows Event Logs Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform]

5 participants

@nicpenning @elasticmachine @marc-gr @pierrehilbert @andrewkroh