Skip to content

akamai: handle input leniently #10158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
efd6 merged 7 commits into from
Nov 11, 2024
Merged

akamai: handle input leniently #10158

efd6 merged 7 commits into from
Nov 11, 2024

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Jun 17, 2024 •
edited
Loading

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 added enhancement New feature or request Integration:akamai Akamai (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jun 17, 2024
@efd6 efd6 self-assigned this Jun 17, 2024
efd6
efd6 commented Jun 17, 2024
View reviewed changes
packages/akamai/data_stream/siem/elasticsearch/ingest_pipeline/default.yml Outdated
Copy link
Contributor Author

@efd6 efd6 Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alternative here is to stash them somewhere; I don't think that is worth it since they original data is still in the event.original.
Copy link
Contributor

@chrisberkhout chrisberkhout Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add error.message: "exception during base64 decoding"?
Copy link
Contributor Author

@efd6 efd6 Nov 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would cause the tests to fail since the vectors here are intentionally corrupted. I've added a place-holder.
@elasticmachine
Copy link

elasticmachine commented Jun 17, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Jun 23, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@botelastic
Copy link

botelastic bot commented Jul 23, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!
@botelastic botelastic bot added the Stalled label Jul 23, 2024
@botelastic
Copy link

botelastic bot commented Aug 22, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!
@botelastic botelastic bot added the Stalled label Aug 22, 2024
@efd6 efd6 removed the Stalled label Aug 28, 2024
@botelastic
Copy link

botelastic bot commented Sep 27, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!
@botelastic botelastic bot added the Stalled label Sep 27, 2024
@efd6 efd6 removed the Stalled label Sep 27, 2024
@efd6 efd6 marked this pull request as ready for review November 4, 2024 20:48
@efd6 efd6 requested a review from a team as a code owner November 4, 2024 20:48
@elasticmachine
Copy link

elasticmachine commented Nov 4, 2024

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
chrisberkhout
chrisberkhout requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments
packages/akamai/data_stream/siem/elasticsearch/ingest_pipeline/default.yml Outdated
Copy link
Contributor

@chrisberkhout chrisberkhout Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add error.message: "exception during base64 decoding"?
@efd6 efd6 requested a review from chrisberkhout November 10, 2024 22:29
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Nov 10, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@elasticmachine
Copy link

elasticmachine commented Nov 10, 2024

💚 Build Succeeded

History

cc @efd6
@efd6 efd6 merged commit e0f3148 into elastic:main Nov 11, 2024
5 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 11, 2024

Package akamai - 2.26.0 containing this change is available at https://epr.elastic.co/package/akamai/2.26.0/
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@efd6
akamai: handle input leniently (elastic#10158)
189961b 
Also remove all redundant null-safe operators.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@efd6
akamai: handle input leniently (elastic#10158)
f5875d2 
Also remove all redundant null-safe operators.
@efd6 efd6 deleted the 10084-akamai branch February 5, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:akamai Akamai (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants

@efd6 @elasticmachine @chrisberkhout @andrewkroh