Skip to content

Conversation

@gogochan
Copy link
Contributor

@gogochan gogochan commented Jun 13, 2024

Proposed commit message

https://github.com/elastic/sdh-beats/issues/4823

The changes introduced in #9102 caused Cisco IOS integration not to handle system messages anymore. This PR fixes it.

‼️ The payload generated in the previous branch derived event.timezone from syslog timestamp, which I don't think is accurate representation. But customer may find it annoying.

Before

+ "cisco": { + "ios": { + "facility": "ILPOWER" + } + }, + "ecs": { + "version": "8.11.0" + }, + "event": { + "category": [ + "network" + ], + "code": "IEEE_DISCONNECT", + "original": "<189>Jun 12 18:10:50 10.53.35.85 %ILPOWER-5-IEEE_DISCONNECT: Interface Gi1/0/20: PD removed", + "provider": "firewall", + "severity": 5, + "timezone": "UTC", + "type": [ + "info" + ] + }, + "log": { + "level": "notification", + "syslog": { + "priority": 189 + } + }, + "message": "Interface Gi1/0/20: PD removed", + "observer": { + "product": "IOS", + "type": "firewall", + "vendor": "Cisco" + }, + "tags": [ + "preserve_original_event" + ] 

After

+ "cisco": { + "ios": { + "facility": "ILPOWER" + } + }, + "ecs": { + "version": "8.11.0" + }, + "event": { + "category": [ + "network" + ], + "code": "IEEE_DISCONNECT", + "original": "<189>Jun 12 18:10:50 10.53.35.85 %ILPOWER-5-IEEE_DISCONNECT: Interface Gi1/0/20: PD removed", + "provider": "firewall", + "severity": 5, + "type": [ + "info" + ] + }, + "log": { + "level": "notification", + "syslog": { + "priority": 189 + } + }, + "message": "Interface Gi1/0/20: PD removed", + "observer": { + "product": "IOS", + "type": "firewall", + "vendor": "Cisco" + }, + "tags": [ + "preserve_original_event" + ] } 

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gogochan gogochan added bug Something isn't working, use only for issues Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Jun 13, 2024
@gogochan gogochan marked this pull request as ready for review June 13, 2024 17:32
@gogochan gogochan requested a review from a team as a code owner June 13, 2024 17:32
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gogochan gogochan merged commit 78a9267 into main Jun 17, 2024
@gogochan gogochan deleted the SDH4823 branch June 17, 2024 14:56
@elasticmachine
Copy link

Package cisco_ios - 1.26.10 containing this change is available at https://epr.elastic.co/search?package=cisco_ios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:cisco_ios Cisco IOS Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

5 participants