Skip to content

all: fix sample events to agree with ECS #10136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
efd6 merged 2 commits into from
Jun 12, 2024
Merged

all: fix sample events to agree with ECS #10136

efd6 merged 2 commits into from
Jun 12, 2024

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Jun 12, 2024 •
edited
Loading

Proposed commit message

* cisco_umbrella * forgerock * lumos * mattermost * microsoft_exchange_online_message_trace * pulse_connect_secure * sentinel_one * ti_cybersixgill * trend_micro_vision_one Also fix missed changelog entry link in crowdstrike package.

The first commit was generated with

for p in cisco_umbrella forgerock lumos mattermost microsoft_exchange_online_message_trace pulse_connect_secure sentinel_one ti_cybersixgill trend_micro_vision_one; do ( cd $p; elastic-package test system -g && \ elastic-package build && \ elastic-package changelog add \ --type bugfix \ --next patch \ --description 'Fix sample event.' \ --link https://github.com/elastic/integrations/pull/10136 ); done

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jun 12, 2024
@efd6 efd6 self-assigned this Jun 12, 2024
efd6 added 2 commits June 12, 2024 13:06
@efd6
all: fix sample events to agree with ECS
6700e2b 
* cisco_umbrella * forgerock * lumos * mattermost * microsoft_exchange_online_message_trace * pulse_connect_secure * sentinel_one * ti_cybersixgill * trend_micro_vision_one
@efd6
crowdstrike: fix changelog entry
090c078
@efd6 efd6 force-pushed the st9309-ecs-samples branch from 3235777 to 090c078 Compare June 12, 2024 03:37
@efd6 efd6 mentioned this pull request Jun 12, 2024
Merged
4 tasks
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Jun 12, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2024

💚 Build Succeeded

cc @efd6
@efd6 efd6 marked this pull request as ready for review June 12, 2024 04:02
@efd6 efd6 requested a review from a team as a code owner June 12, 2024 04:02
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2024

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@efd6 efd6 marked this pull request as draft June 12, 2024 04:05
@efd6 efd6 marked this pull request as ready for review June 12, 2024 06:57
kcreddy
kcreddy approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using -next instead of bumping patch, as the change is related to running just the tests?
packages/cisco_umbrella/data_stream/log/sample_event.json
"data_stream": {
"dataset": "cisco_umbrella.log",
"namespace": "ep",
"namespace": "27145",
Copy link
Contributor

@kcreddy kcreddy Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change related to new elastic-package version?
Copy link
Contributor Author

@efd6 efd6 Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I run ep at tip and this was changed in elastic/elastic-package@3cc9d99.
@efd6 efd6 merged commit 3e97417 into elastic:main Jun 12, 2024
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2024

Package cisco_umbrella - 1.24.1 containing this change is available at https://epr.elastic.co/search?package=cisco_umbrella
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2024

Package forgerock - 1.17.1 containing this change is available at https://epr.elastic.co/search?package=forgerock
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2024

Package lumos - 1.2.1 containing this change is available at https://epr.elastic.co/search?package=lumos
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2024

Package mattermost - 2.0.1 containing this change is available at https://epr.elastic.co/search?package=mattermost
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2024

Package microsoft_exchange_online_message_trace - 1.21.1 containing this change is available at https://epr.elastic.co/search?package=microsoft_exchange_online_message_trace
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2024

Package pulse_connect_secure - 2.0.1 containing this change is available at https://epr.elastic.co/search?package=pulse_connect_secure
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2024

Package sentinel_one - 1.23.1 containing this change is available at https://epr.elastic.co/search?package=sentinel_one
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2024

Package ti_cybersixgill - 1.29.1 containing this change is available at https://epr.elastic.co/search?package=ti_cybersixgill
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2024

Package trend_micro_vision_one - 1.19.1 containing this change is available at https://epr.elastic.co/search?package=trend_micro_vision_one
@efd6 efd6 mentioned this pull request Jun 18, 2024
Merged
4 tasks
@andrewkroh andrewkroh added Integration:mattermost Mattermost (Community supported) Integration:microsoft_exchange_online_message_trac Microsoft Exchange Online Message Trace Integration:pulse_connect_secure Pulse Connect Secure (Community supported) Integration:sentinel_one SentinelOne Integration:ti_cybersixgill Cybersixgill Integration:cisco_umbrella Cisco Umbrella Integration:lumos Lumos (Partner supported) labels Jul 22, 2024
@efd6 efd6 deleted the st9309-ecs-samples branch February 5, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cisco_umbrella Cisco Umbrella Integration:crowdstrike CrowdStrike Integration:forgerock ForgeRock Integration:lumos Lumos (Partner supported) Integration:mattermost Mattermost (Community supported) Integration:microsoft_exchange_online_message_trac Microsoft Exchange Online Message Trace Integration:pulse_connect_secure Pulse Connect Secure (Community supported) Integration:sentinel_one SentinelOne Integration:ti_cybersixgill Cybersixgill Integration:trend_micro_vision_one Trend Micro Vision One Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants

@efd6 @elasticmachine @kcreddy @andrewkroh