Skip to content

Conversation

ricardo-estc
Copy link
Contributor

Add file path to Security events

Change Summary

  • Updates macOS custom documentation for security events
  • Enriches security events schema with a file path. It can be used for various actions, such as gatekeeper override

Sample values

Sample document:

Release Target

Q/A

For mapping changes:

  • I ran make after making the schema changes, and committed all changes
  • If these field(s) are "exception"-able, I made a companion PR to Kibana adding it (see Readme)
  • If this is a metadata change, I also updated both transform destination schemas to match

For Transform changes:

  • The new transform successfully starts in Kibana
  • The corresponding transform destination schema was updated if necessary
Add file path to Security events
@ricardo-estc ricardo-estc requested review from a team as code owners January 29, 2025 08:57
Copy link
Contributor

@ferullo ferullo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change needed for 8.18 or 9.0?

Comment on lines 76 to 78
- file.path
- file.code_signature.signing_id
- file.code_signature.team_id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three fields look out of alphabetical order.

Comment on lines 71 to 73
| file.path |
| file.code_signature.signing_id |
| file.code_signature.team_id |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These file fields look out of alphabetical order.

@ricardo-estc
Copy link
Contributor Author

@ferullo 9.0

Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update package/endpoint/data_stream/security/sample_event.json with example values for

  • file.path
  • file.code_signature.signing_id
  • file.code_signature.team_id

Other than that, this looks ok to squeeze into 9.0, if we can merge soon

@ricardo-estc
Copy link
Contributor Author

@ashokaditya reordered the fields in alphabetical order
@pzl updated sample_event.json

@pzl
Copy link
Member

pzl commented Jan 30, 2025

@ricardo-estc content of PR looks good, I think CI error is just about formatting on that sample event json. I'm guessing the space after the key names and before the :

@ricardo-estc ricardo-estc merged commit ee8d506 into main Jan 30, 2025
4 checks passed
@ricardo-estc ricardo-estc deleted the ricardo/add_file_security_event branch January 30, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants