Fix kibana version condition and additional buildkite settings #473
Conversation
| print(find_oldest_supported_version(kibana_version_condition), end="") | ||
| kibana_version_condition = "" | ||
| if "kibana.version" in manifest_doc["conditions"]: | ||
| kibana_version_condition = manifest_doc["conditions"]["kibana.version"] |
There was a problem hiding this comment.
thanks, this will be nice if we end up having to backport further to 8.11 or something. 8.12 was where we made this yaml change
| cancel_intermediate_builds_branch_filter: '!main !8.12' | ||
| skip_intermediate_builds: true | ||
| # Do accidently skip main or release branch that may be in the middle of releasing | ||
| skip_intermediate_builds_branch_filter: '!main !8.12' |
There was a problem hiding this comment.
can you explain what's going on here?
There was a problem hiding this comment.
I meant to say, "do not". I will update the comment. Basically skip_intermediate_builds cancels any currently running CI and starts a new one if the branch gets updated. For PR CI, it is not a big deal, since it doesn't involve signing and publishing. But for main or other releasable branch, we may not want to cancel pending publishing job because the branch was updated.
This setting means, only skip or cancel CI, if target branch is NOT main or NOT 8.12
There was a problem hiding this comment.
do we need to extend these things every release? e.g. when we cut an 8.13 release branch should this become !main !8.12 !8.13? I guess that also goes for branch_configuration above.
There was a problem hiding this comment.
Yes, unfortunately. The condition does not take regex afaik, and we wouldn't want to have something like 8.*
| Package endpoint - 8.13.0 containing this change is available at https://epr.elastic.co/search?package=endpoint |
3 participants
Change Summary
Integration team used the same file .buildkite/scripts/find_oldest_supported_version.py, and made update to it. https://github.com/elastic/integrations/blob/main/.buildkite/scripts/find_oldest_supported_version.py
This file picks up some of the changes they introduced.
Also adding some condition logic to prevent accidental cancelation of main and 8.12 branch CI job.
Sample values
Buildkite only changes
Release Target
Q/A
For mapping changes:
makeafter making the schema changes, and committed all changesmetadatachange, I also updated both transform destination schemas to matchFor Transform changes: