Skip to content

Conversation

@AsuNa-jp
Copy link
Contributor

@AsuNa-jp AsuNa-jp commented Dec 1, 2023

Change Summary

This PR renames the following ECS fileds at custom_api.yml and its sample_event.json

  • metadata.module_name to metadata.start_address_module
  • metadata.allocation_protection to metadata.start_address_allocation_protection

Sample values

Sample values/document are written in the previous PR.

Release Target

Q/A

For mapping changes:

  • I ran make after making the schema changes, and committed all changes
  • If these field(s) are "exception"-able, I made a companion PR to Kibana adding it (see Readme)
  • If this is a metadata change, I also updated both transform destination schemas to match

For Transform changes:

  • The new transform successfully starts in Kibana
  • The corresponding transform destination schema was updated if necessary
@AsuNa-jp AsuNa-jp requested a review from a team as a code owner December 1, 2023 09:53
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 1, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-01T10:13:29.174+0000

  • Duration: 7 min 5 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@AsuNa-jp AsuNa-jp self-assigned this Dec 1, 2023
Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making a quick fix!

@ashokaditya ashokaditya requested a review from pzl December 1, 2023 10:15
@AsuNa-jp AsuNa-jp merged commit 8801126 into main Dec 1, 2023
@AsuNa-jp AsuNa-jp deleted the asuka_api_fieldfix branch December 4, 2023 07:46
pzl pushed a commit that referenced this pull request Dec 11, 2023
@elasticmachine
Copy link
Contributor

Package endpoint - 8.12.0 containing this change is available at https://epr.elastic.co/search?package=endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants