Fix mapping error by replacing string with keyword #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ashokaditya approved these changes Jun 12, 2023
dasansol92 approved these changes Jun 12, 2023
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
| Going to merge this as it's blocking downstream work, we can update the |
ashokaditya added a commit to ashokaditya/kibana that referenced this pull request Jun 12, 2023
1 task
kevinlog added a commit to elastic/kibana that referenced this pull request Jun 12, 2023
) ## Summary Unskip Endpoint API tests after package fix: elastic/endpoint-package#373 Flaky runner to check that tests are passing: https://ci-stats.kibana.dev/trigger_flaky_test_runner/3 resolves: #72874 #159450 #147640 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
3 tasks
| Package endpoint - 8.9.0 containing this change is available at https://epr.elastic.co/search?package=endpoint |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes a mapping error due to the inclusion of
type: stringin a recent change. The proposed change is to usetype: keywordin place.Failing test where this was caught: elastic/kibana#147640
Release Target
8.9
For mapping changes:
makeafter making the schema changes, and committed all changesmetadatachange, I also updated both transform destination schemas to match