Adapt Question Answering processing for non-batched evaluation #98167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
davidkyle added >bug :ml 
| Pinging @elastic/ml-core (Team:ML) |
| Hi @davidkyle, I've created a changelog YAML for you. |
davidkyle commented Aug 3, 2023
💚 Backport successful
|
davidkyle added a commit to davidkyle/elasticsearch that referenced this pull request Aug 7, 2023
elasticsearchmachine pushed a commit that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The change from batch to iterative processing in elastic/ml-cpp#2538 had a side effect of changing the response format for Question Answering models where the input is longer than the max sequence length and must be spanned over multiple windows.
Previously the output was a 3d array of doubles with the 2 elements in the first dimension structured as:
Where
startis always 0,endalways 1 andspan_indexis no greater than the number of spans/windowsThe new format combines the span index and start/end in the 1st dimension and the 2nd dimension is always of size 1.
Closes #97917