Support for Byte and Short as vector tiles value tag #97619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
iverase added >bug :Analytics/Geo 
elasticsearchmachine added the Team:Analytics 
| Pinging @elastic/es-analytics-geo (Team:Analytics) |
| Hi @iverase, I've created a changelog YAML for you. |
iverase changed the title 
craigtaverner approved these changes Jul 12, 2023
💔 Backport failed
You can use sqren/backport to manually backport by running |
iverase added a commit to iverase/elasticsearch that referenced this pull request Jul 14, 2023
Byte and short data types are not supported by the vector tiles specification. If a user tries to add one of those, it actually gets ignored. This add s support to those values by casting them as integers. In addition it will throw an exception if the value added is a type it cannot understand so it is not silently ignored.
iverase added a commit to iverase/elasticsearch that referenced this pull request Jul 14, 2023
Byte and short data types are not supported by the vector tiles specification. If a user tries to add one of those, it actually gets ignored. This add s support to those values by casting them as integers. In addition it will throw an exception if the value added is a type it cannot understand so it is not silently ignored. # Conflicts: # x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/vector-tile/10_basic.yml
elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2023
Byte and short data types are not supported by the vector tiles specification. If a user tries to add one of those, it actually gets ignored. This add s support to those values by casting them as integers. In addition it will throw an exception if the value added is a type it cannot understand so it is not silently ignored.
elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2023
…97673) * Port lucene fix github-12352 to Elasticsearch 7.17 * Update docs/changelog/96721.yaml * Support for Byte and Short as vector tiles value tag (#97619) Byte and short data types are not supported by the vector tiles specification. If a user tries to add one of those, it actually gets ignored. This add s support to those values by casting them as integers. In addition it will throw an exception if the value added is a type it cannot understand so it is not silently ignored. # Conflicts: # x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/vector-tile/10_basic.yml
This was referenced Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Byte and short data types are not supported by the vector tiles specification. If a user tries to add one of those, it actually gets ignored. This PR proposes to add those values by casting them as integers. In addition it will throw an exception if the value added is a type it cannot understand so it is not silently ignored.
fixes #97612