[8.9] Fix cluster settings update task acknowledgment (#97111) #97148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ClusterUpdateSettingsTask uses a "changed" variable to set the value of the acknowledged flag of the ClusterUpdateSettingsResponse that is returned to the client. The "changed" variable is computed from the cluster state update but there is no guarantee that the update will be acknowledged. In case the update failed to be acked (onAckFailure) it should return the flag appropriately.
tlrx added :Distributed Coordination/Cluster Coordination 
| @elasticmachine run elasticsearch-ci/part-1 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.9: