Skip to content

Conversation

@craigtaverner
Copy link
Contributor

@craigtaverner craigtaverner commented Jun 22, 2023

Two conflicting PR's were merged:

In order to get the second one in, I removed the auto-merge from the first one. This should have caused the first one to fail to merge due to git conflict, and so it would get updated to 021 and then merge. Sadly, both PR's got merged, so we have uncompilable code.

Two conflicting PR's were merged
@craigtaverner craigtaverner added >bug :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team labels Jun 22, 2023
@craigtaverner craigtaverner requested a review from thecoop June 22, 2023 12:12
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@thecoop
Copy link
Member

thecoop commented Jun 22, 2023

Do we need to add 21 at all? Can't we just leave it at 20?

Copy link
Member

@thecoop thecoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for expediency - adding a new TV doesn't affect anything

@craigtaverner craigtaverner merged commit 6633b4b into elastic:main Jun 22, 2023
@craigtaverner craigtaverner deleted the fix_transportversion_conflict branch October 20, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v8.10.0

4 participants