API rest compatibility for type parameter in geo_bounding_box query #96317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
iverase added >bug :Analytics/Geo 
| Hi @iverase, I've created a changelog YAML for you. |
elasticsearchmachine added the Team:Analytics | Pinging @elastic/es-analytics-geo (Team:Analytics) |
craigtaverner approved these changes May 24, 2023
| "geo bounding box query compatible": | ||
| - do: | ||
| headers: | ||
| Content-Type: "application/vnd.elasticsearch+json;compatible-with=7" |
There was a problem hiding this comment.
Interesting, I did not know we could switch on compatibility with headers like this.
| && TYPE_FIELD.match(currentFieldName, parser.getDeprecationHandler())) { | ||
| deprecationLogger.compatibleCritical("geo_bounding_box_type", TYPE_PARAMETER_DEPRECATION_MESSAGE); | ||
| parser.text(); // ignore value | ||
| } else { |
There was a problem hiding this comment.
Indenting looks odd, but since it passed spotless I assume it is correct.
💚 Backport successful
|
iverase added a commit to iverase/elasticsearch that referenced this pull request May 24, 2023
…lastic#96317) The parameter was removed in version 8.0.0 but it should be supported in the Rest API with compatibility to v7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The parameter was removed in version 8.0.0 but it should be supported in the Rest API with compatibility to v7.