Various small cleanups to IngestDocument and some processors #95262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It's not actually valid anymore, it should have been removed a while ago.
So just expand all the callers to invoke the other one instead
joegallo added :Data Management/Ingest Node 
Collaborator
| Pinging @elastic/es-data-management (Team:Data Management) |
Unmodifiables do allocations on many getters, so it's worth the up-front cost to pre-allocate a better collection that's used a billion times than to cheaply build a worse collection.
The lists don't need to mutable anyway, and copyOf is free in the expected case of the passed-in lists already being immutable.
joegallo force-pushed the ingest-document-cleanup branch from 5c71853 to 6d6c7f1 Compare The processors and onFailureProcessors are created with a List.copyOf, but this list was not. The end result is that those lists were an ImmutableCollections.ListN while this one was an UnmodifiableList wrapping an ArrayList (read the docs on the toList method for the details). Anyway, it's the tiniest thing, but I'm in a tidying mood, and it pleases me to have these three lists all be the same type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Just a collection of small tweaks. Some commits I've had lying around for a while, mostly to fix little things that are wrong or resolve some complaint or other from IntelliJ.
edit: I temporarily marked this as WIP because there was an unexpected failure from Jenkins. I squared that away, though, so the label has been removed.