Update apm agent to 1.36.0 #94716
Merged
Update apm agent to 1.36.0 #94716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
elasticsearchmachine added v8.8.0 external-contributor elasticsearchmachine added the needs:triage 
pugnascotia reviewed Mar 24, 2023
elasticsearchmachine added Team:Core/Infra 
| Pinging @elastic/es-core-infra (Team:Core/Infra) |
Yes, just starting ES locally, so only a single node, if you have the chance to double check with a 2+ node cluster that would probably be safer. |
| Thanks @SylvainJuge. I've created #94730 to also put a process in place to ensure we're keeping the bundled agent up to date. |
| @SylvainJuge I built a Docker image from your branch and tested a 3 node ES cluster with Kibana, and it all seems to work, so long as I have agent debug logging disabled. Initially, I didn't notice that I had the agent running with debug logging, and that did indeed seems to break a lot of span recording. But without debugging, all good. |
| Thanks for checking that @pugnascotia ! |
pugnascotia approved these changes Mar 24, 2023
| @elasticmachine run elasticsearch-ci/docs |
tvernum pushed a commit to tvernum/elasticsearch that referenced this pull request Apr 19, 2023
Fixes elastic#94689. The APM agent version 1.33.0 fails to start on JDK 20, which prevents the APM integration to work as expected. As a consequence, the tracing does not work. When setting `ELASTIC_APM_LOG_LEVEL=debug` and `ELASTIC_APM_LOG_FILE=/tmp/log.txt`, the agent log shows that there is an issue with accessing `Unsafe` (sorry I don't have the exact stack trace). There was a few changes in APM agent regarding the security manager (SM) in recent versions, and updating the agent seems to make it work as expected. However, there is one known caveat so far (elastic/apm-agent-java#3074), keeping the agent with `debug` log level with `ELASTIC_APM_LOG_LEVEL=debug` makes it trigger another security exception when trying to establish connection with apm-server because the agent prints few details if a proxy is used or not (which is forbidden by default by the SM and isn't yet wrapped in a privileged call. Backport of: elastic#94716
tvernum added a commit that referenced this pull request Apr 19, 2023
The APM agent version 1.33.0 fails to start on JDK 20, which prevents the APM integration to work as expected. As a consequence, the tracing does not work. When setting `ELASTIC_APM_LOG_LEVEL=debug` and `ELASTIC_APM_LOG_FILE=/tmp/log.txt`, the agent log shows that there is an issue with accessing `Unsafe` (sorry I don't have the exact stack trace). There was a few changes in APM agent regarding the security manager (SM) in recent versions, and updating the agent seems to make it work as expected. However, there is one known caveat so far (elastic/apm-agent-java#3074), keeping the agent with `debug` log level with `ELASTIC_APM_LOG_LEVEL=debug` makes it trigger another security exception when trying to establish connection with apm-server because the agent prints few details if a proxy is used or not (which is forbidden by default by the SM and isn't yet wrapped in a privileged call. Backport of: #94716 Co-authored-by: SylvainJuge <sylvain.juge@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes #94689
The APM agent version 1.33.0 fails to start on JDK 20, which prevents the APM integration to work as expected.
As a consequence, the tracing does not work.
When setting
ELASTIC_APM_LOG_LEVEL=debugandELASTIC_APM_LOG_FILE=/tmp/log.txt, the agent log shows that there is an issue with accessingUnsafe(sorry I don't have the exact stack trace).There was a few changes in APM agent regarding the security manager (SM) in recent versions, and updating the agent seems to make it work as expected.
However, there is one known caveat so far (elastic/apm-agent-java#3074), keeping the agent with
debuglog level withELASTIC_APM_LOG_LEVEL=debugmakes it trigger another security exception when trying to establish connection with apm-server because the agent prints few details if a proxy is used or not (which is forbidden by default by the SM and isn't yet wrapped in a privileged call.