[Transform] Catch deprecations as Exception rather than IOException #94553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Pinging @elastic/ml-core (Team:ML) |
| Hi @przemekwitek, I've created a changelog YAML for you. |
droberts195 approved these changes Mar 20, 2023
💚 Backport successful
|
przemekwitek added a commit to przemekwitek/elasticsearch that referenced this pull request Mar 20, 2023
elasticsearchmachine pushed a commit that referenced this pull request Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR changes the exception type (from
IOExceptiontoException) caught when callingQueryConfig.checkForDeprecationsmethod.The goal is to catch the deprecation exceptions with type other than
IOExceptionso that they are reported properly to the user.