Fix unhandled exception when blobstore repository contains unexpected file #93914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… file If there's any file with the `index-` prefix but not a number after that at the repo root we must not throw here. If we do, we will end up throwing an unexpected exception that is not properly handled by `org.elasticsearch.snapshots.SnapshotsService#failAllListenersOnMasterFailOver`, leading to the repository generation not getting correctly set in the cluster state down the line.
original-brownbear added >bug :Distributed Coordination/Snapshot/Restore 
elasticsearchmachine added the Team:Distributed (Obsolete) 
| Pinging @elastic/es-distributed (Team:Distributed) |
| Hi @original-brownbear, I've created a changelog YAML for you. |
| return repositoryData.getGenId() > Long.parseLong(blob.substring(INDEX_FILE_PREFIX.length())); | ||
| } catch (NumberFormatException nfe) { | ||
| // odd case of an extra file with the index- prefix that we can't identify | ||
| return false; |
There was a problem hiding this comment.
Should we log that we discovered unexpected file in repository?
There was a problem hiding this comment.
I'm mildly worried this could get really spammy in some cases and we do already log this specific case in org.elasticsearch.repositories.blobstore.BlobStoreRepository#latestGeneration actually.
This is hopefully an edge case to the point where we won't have to worry much about it :)
idegtiarenko approved these changes Feb 20, 2023
arteam approved these changes Feb 20, 2023
There was a problem hiding this comment.
LGTM2. @original-brownbear Does it make sense to backport the fix?
| Thanks both + jup lets backport this :) |
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Feb 20, 2023
… file (elastic#93914) If there's any file with the `index-` prefix but not a number after that at the repo root we must not throw here. If we do, we will end up throwing an unexpected exception that is not properly handled by `org.elasticsearch.snapshots.SnapshotsService#failAllListenersOnMasterFailOver`, leading to the repository generation not getting correctly set in the cluster state down the line.
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine pushed a commit that referenced this pull request Feb 20, 2023
… file (#93914) (#93942) If there's any file with the `index-` prefix but not a number after that at the repo root we must not throw here. If we do, we will end up throwing an unexpected exception that is not properly handled by `org.elasticsearch.snapshots.SnapshotsService#failAllListenersOnMasterFailOver`, leading to the repository generation not getting correctly set in the cluster state down the line.
carlosdelest pushed a commit to carlosdelest/elasticsearch that referenced this pull request Feb 21, 2023
… file (elastic#93914) If there's any file with the `index-` prefix but not a number after that at the repo root we must not throw here. If we do, we will end up throwing an unexpected exception that is not properly handled by `org.elasticsearch.snapshots.SnapshotsService#failAllListenersOnMasterFailOver`, leading to the repository generation not getting correctly set in the cluster state down the line.
joegallo added a commit to joegallo/elasticsearch that referenced this pull request Jun 26, 2023
… file (elastic#93914) If there's any file with the `index-` prefix but not a number after that at the repo root we must not throw here. If we do, we will end up throwing an unexpected exception that is not properly handled by `org.elasticsearch.snapshots.SnapshotsService#failAllListenersOnMasterFailOver`, leading to the repository generation not getting correctly set in the cluster state down the line.
joegallo added a commit that referenced this pull request Jun 27, 2023
… file (#93914) (#97113) If there's any file with the `index-` prefix but not a number after that at the repo root we must not throw here. If we do, we will end up throwing an unexpected exception that is not properly handled by `org.elasticsearch.snapshots.SnapshotsService#failAllListenersOnMasterFailOver`, leading to the repository generation not getting correctly set in the cluster state down the line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If there's any file with the
index-prefix but not a number after that at the repo root we must not throw here. If we do, we will end up throwing an unexpected exception that is not properly handled byorg.elasticsearch.snapshots.SnapshotsService#failAllListenersOnMasterFailOver, leading to the repository generation not getting correctly set in the cluster state down the line.Just like with other unexpected files in the repository, we should be able to deal with this one transparently.