Avoid NPE in DiskThresholdMonitor #93699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pxsalehi added >bug :Distributed Coordination/Allocation 
| Hi @pxsalehi, I've created a changelog YAML for you. |
| Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine added the Team:Distributed (Obsolete) 
DaveCTurner reviewed Feb 10, 2023
…pxsalehi/elasticsearch into ps230210-avoidNPEInDiskThresholdMonitor
…DiskThresholdMonitor
DaveCTurner approved these changes Feb 13, 2023
| assertEquals(Set.of("test"), result.v2()); | ||
| | ||
| final ClusterState blockedClusterState = ClusterState.builder(clusterState) | ||
| .blocks(ClusterBlocks.builder().addGlobalBlock(GatewayService.STATE_NOT_RECOVERED_BLOCK).build()) |
There was a problem hiding this comment.
nit: we should also have an empty routing table in this state (the routing table is initialised when removing GatewayService.STATE_NOT_RECOVERED_BLOCK)
| DiscoveryNodes.Builder discoveryNodes = DiscoveryNodes.builder() | ||
| .add(newNormalNode("node1", "node1")) | ||
| .add(newNormalNode("node2", "node2")); | ||
| // node3 which is to replace node1 may or may not bee in the cluster |
There was a problem hiding this comment.
typo :)
Suggested change
| // node3 which is to replace node1 may or may not bee in the cluster | |
| // node3 which is to replace node1 may or may not be in the cluster |
pxsalehi added a commit to pxsalehi/elasticsearch that referenced this pull request Feb 13, 2023
- Process new ClusterInfo only when the cluster state is recovered, since we need to know the indices/nodes in the cluster for this. - Avoid missing node IDs that could result from a REPLACE shutdown metadata. Both of these could lead to NPEs which is not fatal in 8.7/8.8, but could lead to unresolved listeners on 7.17.
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine pushed a commit that referenced this pull request Feb 13, 2023
- Process new ClusterInfo only when the cluster state is recovered, since we need to know the indices/nodes in the cluster for this. - Avoid missing node IDs that could result from a REPLACE shutdown metadata. Both of these could lead to NPEs which is not fatal in 8.7/8.8, but could lead to unresolved listeners on 7.17.
pxsalehi added a commit to pxsalehi/elasticsearch that referenced this pull request Feb 13, 2023
- Process new ClusterInfo only when the cluster state is recovered, since we need to know the indices/nodes in the cluster for this. - Avoid missing node IDs that could result from a REPLACE shutdown metadata. Both of these could lead to NPEs which is not fatal in 8.7/8.8, but could lead to unresolved listeners on 7.17.
elasticsearchmachine pushed a commit that referenced this pull request Feb 15, 2023
* Fix Gradle project evaluation when runtime java home is unset * Avoid NPE in DiskThresholdMonitor (#93699) - Process new ClusterInfo only when the cluster state is recovered, since we need to know the indices/nodes in the cluster for this. - Avoid missing node IDs that could result from a REPLACE shutdown metadata. Both of these could lead to NPEs which is not fatal in 8.7/8.8, but could lead to unresolved listeners on 7.17. --------- Co-authored-by: Mark Vieira <portugee@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
carlosdelest pushed a commit to carlosdelest/elasticsearch that referenced this pull request Feb 21, 2023
- Process new ClusterInfo only when the cluster state is recovered, since we need to know the indices/nodes in the cluster for this. - Avoid missing node IDs that could result from a REPLACE shutdown metadata. Both of these could lead to NPEs which is not fatal in 8.7/8.8, but could lead to unresolved listeners on 7.17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
ClusterInfoonly when the cluster state is recovered, since we need to know the indices/nodes in the cluster for this.REPLACEshutdown metadata.Both of these could lead to NPEs which is not fatal in 8.7/8.8, but could lead to unresolved listeners on 7.17.