Fix integer overflow in AsyncTaskIndexService #91044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
If source is larger than int_max we overflow on the multiplication. Since we didn't use the same variable we will increment the breaker once and then increment it again with the broken overflown int on release.
original-brownbear added >bug :Search/Search 
| Pinging @elastic/es-search (Team:Search) |
| Hi @original-brownbear, I've created a changelog YAML for you. |
| np + thanks for reviewing! |
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Oct 20, 2022
If source is larger than int_max we overflow on the multiplication. Since we didn't use the same variable we will increment the breaker once and then increment it again with the broken overflown int on release.
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Oct 20, 2022
If source is larger than int_max we overflow on the multiplication. Since we didn't use the same variable we will increment the breaker once and then increment it again with the broken overflown int on release.
elasticsearchmachine pushed a commit that referenced this pull request Oct 20, 2022
elasticsearchmachine pushed a commit that referenced this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If source is larger than
int_max/2we overflow on the multiplication. Since we didn't use the same variable we will increment the breaker once and then increment it again with the broken overflown int on release.