Fork to WRITE thread before failing shard in updateCheckPoints #87458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Failing a shard may block on IO so must not happen on a transport worker thread. With this commit we use a `WRITE` thread to handle shard failures caused by exceptions thrown within `updateCheckPoints`. Closes elastic#87094
DaveCTurner added >bug :Distributed Indexing/Engine 
elasticmachine added the Team:Distributed (Obsolete) 
| Pinging @elastic/es-distributed (Team:Distributed) |
| Hi @DaveCTurner, I've created a changelog YAML for you. |
idegtiarenko approved these changes Jun 7, 2022
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jun 8, 2022
…ic#87458) Failing a shard may block on IO so must not happen on a transport worker thread. With this commit we use a `WRITE` thread to handle shard failures caused by exceptions thrown within `updateCheckPoints`. Closes elastic#87094
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jun 8, 2022
…ic#87458) Failing a shard may block on IO so must not happen on a transport worker thread. With this commit we use a `WRITE` thread to handle shard failures caused by exceptions thrown within `updateCheckPoints`. Closes elastic#87094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Failing a shard may block on IO so must not happen on a transport worker
thread. With this commit we use a
WRITEthread to handle shardfailures caused by exceptions thrown within
updateCheckPoints.Closes #87094