FastVectorHighlighter should use ValueFetchers to load source data #87445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…lastic#85815) FVH was relying on `SourceLookup.extractRawValues()` to load its data, but this no longer works for multifields. It should instead use value fetchers which will correctly locate the input for multifields and/or copy fields. Fixes elastic#84690 Fixes elastic#82458 Fixes elastic#80895 Fixes elastic#75011
romseygeek added >bug :Search Relevance/Highlighting 
| Pinging @elastic/es-search (Team:Search) |
| Hi @romseygeek, I've created a changelog YAML for you. |
jtibshirani approved these changes Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
FVH was relying on
SourceLookup.extractRawValues()to load its data, but this nolonger works for multifields. It should instead use value fetchers which will correctly
locate the input for multifields and/or copy fields.
Fixes #84690
Fixes #82458
Fixes #80895
Fixes #75011
Backport of #85815