Security plugin close realms #87429
Merged
Security plugin close realms #87429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
albertzaharovits added the :Security/Security 
| Hi @albertzaharovits, I've created a changelog YAML for you. |
| Pinging @elastic/es-security (Team:Security) |
tvernum reviewed Jun 7, 2022
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/Realms.java Outdated Show resolved Hide resolved
| I think this should be tagged |
slobodanadamovic approved these changes Jun 7, 2022
…ecurity/authc/Realms.java Co-authored-by: Tim Vernum <tim@adjective.org>
Yes, added the label and will merge it there as well. |
| @elasticmachine update branch |
albertzaharovits added auto-merge-without-approval albertzaharovits changed the title | @elasticmachine run elasticsearch-ci/part-1 |
albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request Jun 7, 2022
The `Closeable#close` method on `Realm`s was never called upon node shutdown. This is a problem when realms (eg OIDC) create non-daemon threads that expect to be stopped when the `close` method is invoked. Specifically, it is a problem on Windows where the graceful shutdown is implemented by terminatting all non-daemon threads (see `Bootstrap#stop` and `Bootstrap#initializeNatives`). Closes elastic#86286
albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request Jun 7, 2022
The `Closeable#close` method on `Realm`s was never called upon node shutdown. This is a problem when realms (eg OIDC) create non-daemon threads that expect to be stopped when the `close` method is invoked. Specifically, it is a problem on Windows where the graceful shutdown is implemented by terminatting all non-daemon threads (see `Bootstrap#stop` and `Bootstrap#initializeNatives`). Closes elastic#86286
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine pushed a commit that referenced this pull request Jun 7, 2022
* Security plugin close realms (#87429) The `Closeable#close` method on `Realm`s was never called upon node shutdown. This is a problem when realms (eg OIDC) create non-daemon threads that expect to be stopped when the `close` method is invoked. Specifically, it is a problem on Windows where the graceful shutdown is implemented by terminatting all non-daemon threads (see `Bootstrap#stop` and `Bootstrap#initializeNatives`). Closes #86286 * Add the extension point in LocalStateSecurity
elasticsearchmachine pushed a commit that referenced this pull request Jun 7, 2022
* Security plugin close realms (#87429) The `Closeable#close` method on `Realm`s was never called upon node shutdown. This is a problem when realms (eg OIDC) create non-daemon threads that expect to be stopped when the `close` method is invoked. Specifically, it is a problem on Windows where the graceful shutdown is implemented by terminatting all non-daemon threads (see `Bootstrap#stop` and `Bootstrap#initializeNatives`). Closes #86286 * IOUtils rename around
albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request Jun 7, 2022
The `Closeable#close` method on `Realm`s was never called upon node shutdown. This is a problem when realms (eg OIDC) create non-daemon threads that expect to be stopped when the `close` method is invoked. Specifically, it is a problem on Windows where the graceful shutdown is implemented by terminatting all non-daemon threads (see `Bootstrap#stop` and `Bootstrap#initializeNatives`). Closes elastic#86286
elasticsearchmachine pushed a commit that referenced this pull request Jun 7, 2022
* [7.17] Security plugin close realms (#87429) The `Closeable#close` method on `Realm`s was never called upon node shutdown. This is a problem when realms (eg OIDC) create non-daemon threads that expect to be stopped when the `close` method is invoked. Specifically, it is a problem on Windows where the graceful shutdown is implemented by terminatting all non-daemon threads (see `Bootstrap#stop` and `Bootstrap#initializeNatives`). Closes #86286 * Merge fallout * Spotless * More compilation fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
Closeable#closemethod onRealms was never called upon node shutdown.This is a problem when realms (eg OIDC) create non-daemon threads that expect
to be stopped when the
closemethod is invoked. Specifically, it is a problemon Windows where the graceful shutdown is implemented by terminatting all
non-daemon threads (see
Bootstrap#stopandBootstrap#initializeNatives).Closes #86286