Clean up DeflateCompressor after exception #87163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We must reset the thread-local buffer in `DeflateCompressor` whether the compression succeeds or fails. Closes elastic#87160
DaveCTurner added >bug :Core/Infra/Core 
| Pinging @elastic/es-core-infra (Team:Core/Infra) |
| Hi @DaveCTurner, I've created a changelog YAML for you. |
Comment on lines +392 to +396
| try { | ||
| compressor.uncompress(compressed); | ||
| } catch (ZipException e) { | ||
| // ok | ||
| } |
There was a problem hiding this comment.
Should this fail if exception was not thrown?
There was a problem hiding this comment.
No, there's no checksum or anything so modifying a byte will sometimes yield a valid (but different) output.
idegtiarenko approved these changes May 30, 2022
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request May 30, 2022
We must reset the thread-local buffer in `DeflateCompressor` whether the compression succeeds or fails. Closes elastic#87160
This was referenced May 30, 2022
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request May 30, 2022
We must reset the thread-local buffer in `DeflateCompressor` whether the compression succeeds or fails. Closes elastic#87160
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner added a commit that referenced this pull request May 30, 2022
We must reset the thread-local buffer in `DeflateCompressor` whether the compression succeeds or fails. Closes #87160
elasticsearchmachine pushed a commit that referenced this pull request May 30, 2022
elasticsearchmachine pushed a commit that referenced this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We must reset the thread-local buffer in
DeflateCompressorwhether thecompression succeeds or fails.
Closes #87160