Guard for adding null value tags to vector tiles #87051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
iverase added >bug :Analytics/Geo 
elasticmachine added the Team:Analytics 
| Pinging @elastic/es-analytics-geo (Team:Analytics) |
| Hi @iverase, I've created a changelog YAML for you. |
craigtaverner approved these changes May 23, 2022
iverase added a commit to iverase/elasticsearch that referenced this pull request May 23, 2022
This commit adds a guard so tags with null values are ignored.
💔 Backport failed
You can use sqren/backport to manually backport by running |
iverase added a commit to iverase/elasticsearch that referenced this pull request May 23, 2022
This commit adds a guard so tags with null values are ignored. # Conflicts: # x-pack/plugin/vector-tile/src/javaRestTest/java/org/elasticsearch/xpack/vectortile/VectorTileRestIT.java
elasticsearchmachine pushed a commit that referenced this pull request May 23, 2022
elasticsearchmachine pushed a commit that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It is possible for the fields API to return null objects when a field is set to ignore_malformed values and the values are actually malformed. This causes a NPE on vector tiles if trying to add the value as the value of a tag. This PR adds a guard so tags with null values are ignored.