Fix audit logging to consistently include port number in origin.address #86732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This commit changes audit logging of `connection_denied` and `connection_granted` events in order to include a port number. Closes elastic#86694
slobodanadamovic added >bug :Security/Audit 
| Pinging @elastic/es-security (Team:Security) |
| Hi @slobodanadamovic, I've created a changelog YAML for you. |
albertzaharovits approved these changes May 16, 2022
Added it in commit: 9cfdb9c @albertzaharovits I've marked this PR to auto-backport this fix to versions v7.17.4, v8.0.2, v8.1.4 and v8.2.1. |
slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request May 20, 2022
…ss (elastic#86732) This commit changes audit logging of `connection_denied` and `connection_granted` events in order to include a port number. Closes elastic#86694
💔 Backport failed
You can use sqren/backport to manually backport by running |
slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request May 20, 2022
…ss (elastic#86732) This commit changes audit logging of `connection_denied` and `connection_granted` events in order to include a port number. Closes elastic#86694 (cherry picked from commit 954d288) # Conflicts: # x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/audit/AuditTrail.java # x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/audit/AuditTrailService.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine pushed a commit that referenced this pull request May 20, 2022
…ss (#86732) (#86969) This commit changes audit logging of `connection_denied` and `connection_granted` events in order to include a port number. Closes #86694 (cherry picked from commit 954d288) # Conflicts: # x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/audit/AuditTrail.java # x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/audit/AuditTrailService.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR changes audit logging of
connection_deniedand
connection_grantedevents in order to include a port number.Closes #86694