[Test] Use thread-safe hashSet for result collection #85653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use regular HashSet in a deliberate concurrency code block sometimes results into unexpected behaviour: The hashSet has only a single item but size() reports 2. This PR replaces the regular hashSet with a thread-safe version to fix spurious test failures. Resolves: elastic#85411
ywangd added >test 
| Pinging @elastic/es-security (Team:Security) |
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Apr 12, 2022
Use regular HashSet in a deliberate concurrency code block sometimes results into unexpected behaviour: The hashSet has only a single item but size() reports 2. This PR replaces the regular hashSet with a thread-safe version to fix spurious test failures. Resolves: elastic#85411
💚 Backport successful
|
elasticsearchmachine pushed a commit that referenced this pull request Apr 12, 2022
Use regular HashSet in a deliberate concurrency code block sometimes results into unexpected behaviour: The hashSet has only a single item but size() reports 2. This PR replaces the regular hashSet with a thread-safe version to fix spurious test failures. Resolves: #85411
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Apr 13, 2022
* upstream/master: (40 commits) Fix BuildTests serialization (elastic#85827) Use urgent priority for node shutdown cluster state update (elastic#85838) Remove Task classes from HLRC (elastic#85835) Remove unused migration classes (elastic#85834) Remove uses of Charset name parsing (elastic#85795) Remove legacy versioned logic for DefaultSystemMemoryInfo (elastic#85761) Expose proxy settings for GCS repositories (elastic#85785) Remove SLM classes from HLRC (elastic#85825) TSDB: fix the time_series in order collect priority (elastic#85526) Remove ILM classes from HLRC (elastic#85822) FastVectorHighlighter should use ValueFetchers to load source data (elastic#85815) Iteratively execute synchronous ingest processors (elastic#84250) Remove TransformClient from HLRC (elastic#85787) Mute XPackRestIT deprecation/10_basic/Test Deprecations (elastic#85807) Unmute Lintian packaging test (elastic#85778) Add a highlighter unit test base class (elastic#85719) Remove NIO Transport Plugin (elastic#82085) [TEST] Remove token methods from HLRC SecurityClient (elastic#85515) [Test] Use thread-safe hashSet for result collection (elastic#85653) [TEST] Mute BuildTests.testSerialization (elastic#85801) ... # Conflicts: # server/src/test/java/org/elasticsearch/search/aggregations/timeseries/TimeSeriesIndexSearcherTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Use regular HashSet in a deliberate concurrency code block sometimes
results into unexpected behaviour: The hashSet has only a single item
but size() reports 2. This PR replaces the regular hashSet with a
thread-safe version to fix spurious test failures.
Resolves: #85411